Packaged (CRX) extensions shouldn't be able to get 'dev' interfaces in NaCl.

ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "native_client/src/shared/ppapi_proxy/browser_globals.h"
 
 #include <stddef.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ skipping 38 matching lines @@
 // is requesting PPAPI Dev interfaces to be available.
 // Set by SetPPBGetInterface().
 PPB_GetInterface get_interface = NULL;
 bool enable_dev_interfaces = false;
 
 // Whether Pepper 3D interfaces should be enabled.
 bool enable_3d_interfaces = true;
 
 }  // namespace
 
-// By default, disable developer (Dev) interfaces.  To enable developer
-// interfaces, set the environment variable NACL_ENABLE_PPAPI_DEV to 1.
-// Also, the plugin can request whether or not to enable dev interfaces.
-bool AreDevInterfacesEnabled() {
-  static bool first = true;
-  static bool env_dev_enabled = false;
-  if (first) {
-    const char *nacl_enable_ppapi_dev = getenv("NACL_ENABLE_PPAPI_DEV");
-    if (NULL != nacl_enable_ppapi_dev) {
-      int v = strtol(nacl_enable_ppapi_dev, (char **) 0, 0);
-      if (v != 0) {
-        env_dev_enabled = true;
-      }
-    }
-    first = false;
-  }
-  return env_dev_enabled || enable_dev_interfaces;
-}
-
-
 void SetBrowserPppForInstance(PP_Instance instance, BrowserPpp* browser_ppp) {
   // If there was no map, create one.
   if (instance_to_ppp_map == NULL) {
     instance_to_ppp_map = new std::map<PP_Instance, BrowserPpp*>;
   }
   // Add the instance to the map.
   (*instance_to_ppp_map)[instance] = browser_ppp;
 }
 
 void UnsetBrowserPppForInstance(PP_Instance instance) {
@@ skipping 106 matching lines @@
   enable_3d_interfaces = allow_3d_interfaces;
 }
 
 const void* GetBrowserInterface(const char* interface_name) {
   // Reject suspiciously long interface strings.
   const size_t kMaxLength = 1024;
   if (NULL == memchr(interface_name, '\0', kMaxLength)) {
     return NULL;
   }
   // If dev interface is not enabled, reject interfaces containing "(Dev)"
-  if (!AreDevInterfacesEnabled() && strstr(interface_name, "(Dev)") != NULL) {
+  if (!enable_dev_interfaces && strstr(interface_name, "(Dev)") != NULL) {
     return NULL;
   }
   if (!enable_3d_interfaces) {
     static const char* disabled_interface_names[] = {
       PPB_GRAPHICS_3D_INTERFACE,
       PPB_GRAPHICS_3D_TRUSTED_INTERFACE,
       PPB_CONTEXT_3D_DEV_INTERFACE,
       PPB_CONTEXT_3D_TRUSTED_DEV_INTERFACE,
       PPB_GLES_CHROMIUM_TEXTURE_MAPPING_DEV_INTERFACE,
       PPB_OPENGLES2_INTERFACE,
@@ skipping 214 matching lines @@
 
 // Private interfaces.
 const PPB_PDF* PPBPDFInterface() {
   static const PPB_PDF* ppb =
       static_cast<const PPB_PDF*>(
           GetBrowserInterfaceSafe(PPB_PDF_INTERFACE));
   return ppb;
 }
 
 }  // namespace ppapi_proxy