Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2254)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/download/save_package.cc

Issue 83002: download filename fix (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/history/download_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_package.cc
===================================================================
--- chrome/browser/download/save_package.cc (revision 15065)
+++ chrome/browser/download/save_package.cc (working copy)
@@ -296,8 +296,10 @@
const GURL& url,
bool need_html_ext,
FilePath::StringType* generated_name) {
+ // TODO(jungshik): Figure out the referrer charset when having one
+ // makes sense and pass it to GetSuggestedFilename.
FilePath file_path = FilePath::FromWStringHack(
- net::GetSuggestedFilename(url, disposition, kDefaultSaveName));
+ net::GetSuggestedFilename(url, disposition, "", kDefaultSaveName));
DCHECK(!file_path.empty());
FilePath::StringType pure_file_name =
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/history/download_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698