Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2467)

Unified Diff: chrome/browser/sync/syncable/syncable.cc

Issue 8298016: Making some CHECK statements to NOTREACHED. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Upload before commit. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/process_commit_response_command.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/syncable/syncable.cc
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc
index d974322accb30a0018fae8ca3fe96656d8471278..9038240974bbb63648be871679cb2e464fed778a 100644
--- a/chrome/browser/sync/syncable/syncable.cc
+++ b/chrome/browser/sync/syncable/syncable.cc
@@ -1483,7 +1483,11 @@ bool MutableEntry::PutIsDel(bool is_del) {
}
if (!is_del)
- CHECK(PutPredecessor(Id())); // Restores position to the 0th index.
+ // Restores position to the 0th index.
+ if (!PutPredecessor(Id())) {
+ // TODO(lipalani) : Propagate the error to caller. crbug.com/100444.
+ NOTREACHED();
+ }
return true;
}
@@ -1521,7 +1525,11 @@ bool MutableEntry::Put(IdField field, const Id& value) {
return false;
} else if (PARENT_ID == field) {
PutParentIdPropertyOnly(value); // Makes sibling order inconsistent.
- CHECK(PutPredecessor(Id())); // Fixes up the sibling order inconsistency.
+ // Fixes up the sibling order inconsistency.
+ if (!PutPredecessor(Id())) {
+ // TODO(lipalani) : Propagate the error to caller. crbug.com/100444.
+ NOTREACHED();
+ }
} else {
kernel_->put(field, value);
}
« no previous file with comments | « chrome/browser/sync/engine/process_commit_response_command.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698