Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 8298009: Only warn about undefined symbols if the symbol has been used in a regular object file (Closed)

Created:
9 years, 2 months ago by pdox
Modified:
9 years, 2 months ago
CC:
pnacl-team_google.com
Base URL:
http://code.google.com/p/nacl-llvm-branches.binutils
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M binutils-2.20/gold/symtab.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdox
9 years, 2 months ago (2011-10-14 18:49:22 UTC) #1
Roland McGrath
I don't actually know the gold codebase enough to review this. But if you've tested ...
9 years, 2 months ago (2011-10-14 20:07:28 UTC) #2
pdox
+jvoung
9 years, 2 months ago (2011-10-14 20:15:17 UTC) #3
jvoung - send to chromium...
9 years, 2 months ago (2011-10-14 20:21:38 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698