Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 8298007: Aura: unit_tests now run on Linux (Closed)

Created:
9 years, 2 months ago by James Cook
Modified:
9 years, 2 months ago
CC:
chromium-reviews, dpranke-watch+content_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, jam, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Aura: unit_tests now run on Linux Marked several tests DISABLED and several tests FAILS. Most are due to functionality that isn't implemented yet on Aura. Filed bugs with Feature-Aura for the ones we need to fix. BUG=100352 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105962

Patch Set 1 #

Total comments: 2

Patch Set 2 : only disable tests on non-Win Aura #

Patch Set 3 : fix ui_test_utils_aura Bind #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -9 lines) Patch
M build/all.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/metrics/display_utils_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
Scott, PTAL. I'd like to land the Linux unit_tests first, then try to get Windows ...
9 years, 2 months ago (2011-10-14 18:18:59 UTC) #1
sky
I have this comment on all of these. Should they only be disabled on !OS_WIN ...
9 years, 2 months ago (2011-10-14 20:05:06 UTC) #2
James Cook
Scott, now the tests are disabled only on non-Win Aura. PTAAL.
9 years, 2 months ago (2011-10-14 20:36:02 UTC) #3
James Cook
Emmanuel, Scott is in promo committee all day - can you take a look? Thanks.
9 years, 2 months ago (2011-10-17 21:43:07 UTC) #4
Emmanuel Saint-loubert-Bié
9 years, 2 months ago (2011-10-17 21:45:07 UTC) #5
LGTM thanks for doing this.

Powered by Google App Engine
This is Rietveld 408576698