Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: gclient.py

Issue 8298002: Do not sort solutions anymore, only dependencies specified in DEPS files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gclient_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 27d2ed14972852c35486abe210ac19232bdca6b0..2fd056f8e44e2bc746ddbf711865a8bbd64e4985 100644
--- a/gclient.py
+++ b/gclient.py
@@ -465,12 +465,13 @@ class Dependency(gclient_utils.WorkItem, DependencySettings):
deps_to_add.append(Dependency(
self, name, url, None, None, None, None,
self.deps_file, should_process))
+ deps_to_add.sort(key=lambda x: x.name)
self.add_dependencies_and_close(deps_to_add, local_scope.get('hooks', []))
logging.info('ParseDepsFile(%s) done' % self.name)
def add_dependencies_and_close(self, deps_to_add, hooks):
"""Adds the dependencies, hooks and mark the parsing as done."""
- for dep in sorted(deps_to_add, key=lambda x: x.name):
+ for dep in deps_to_add:
if dep.verify_validity():
self.add_dependency(dep)
self._mark_as_parsed(hooks)
« no previous file with comments | « no previous file | tests/gclient_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698