Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 8298002: Do not sort solutions anymore, only dependencies specified in DEPS files. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Do not sort solutions anymore, only dependencies specified in DEPS files. Otherwise it breaks naked --revision usage. One example issue is linux_chromeos applying the revision to cros_deps instead of src. TBR=dpranke@chromium.org BUG=100335 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M gclient.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/gclient_test.py View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-14 16:46:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8298002/1
9 years, 2 months ago (2011-10-14 17:59:34 UTC) #2
commit-bot: I haz the power
Change committed as 105522
9 years, 2 months ago (2011-10-14 18:05:44 UTC) #3
Dirk Pranke
9 years, 2 months ago (2011-10-14 21:49:58 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698