Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 8297001: Prevents a profile from editing the avatar and profile name of another profile in the Personal Op... (Closed)

Created:
9 years, 2 months ago by jwd
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Prevents a profile from editing the avatar and profile name of another profile in the Personal Options page. This is to make way for syncing those two preferences; we don't want to allow modifying those prefs of profiles that are not loaded.Patch from Jesse Doherty <87658 TEST=NONE">jwd@chromium.org>BUG=87658 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/options/personal_options.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jwd
9 years, 2 months ago (2011-10-14 17:48:12 UTC) #1
csilv
lgtm
9 years, 2 months ago (2011-10-14 17:53:47 UTC) #2
binji
On 2011/10/14 17:53:47, csilv wrote: > lgtm lgtm, thanks!
9 years, 2 months ago (2011-10-14 19:49:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/8297001/1
9 years, 2 months ago (2011-10-14 20:10:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/8297001/1
9 years, 2 months ago (2011-10-25 13:59:19 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 15:15:57 UTC) #6
Change committed as 107118

Powered by Google App Engine
This is Rietveld 408576698