Issue 8296018: Silence GCC-4.5.3 warning about unused result in d8.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8296018: Silence GCC-4.5.3 warning about unused result in d8.cc (Closed)

Created:
9 years, 2 months ago by Jakob Kummerow

Modified:
9 years, 2 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Silence GCC-4.5.3 warning about unused result in d8.cc TEST=GCC 4.5.3 successfully compiles d8.cc even with -Werror enabled. Committed: http://code.google.com/p/v8/source/detail?r=9679

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/d8.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. We don't export the USE(T) template, so d8.cc has to roll its own solution.

9 years, 2 months ago (2011-10-15 14:36:59 UTC) #1

Sven Panne

9 years, 2 months ago (2011-10-18 09:25:38 UTC) #2

LGTM

http://codereview.chromium.org/8296018/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/8296018/diff/1/src/d8.cc#newcode182
src/d8.cc:182: (void) count;  // Silence GCC-4.5.x "unused result" warning.
FYI only: I've just checked that simply using "(void) fwrite(...)" is not enough
to silence GCC, so we really need this intermediate dummy variable. If somebody
is interested there are epic discussions about the (non-)sense of making fwrite
and friend wur at https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/305176
and http://sourceware.org/bugzilla/show_bug.cgi?id=11959, and probably more
places... :-)

Expand Messages | Collapse Messages