Issue 8296016: Parse matroska clusters incrementally as opposed to all at once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8296016: Parse matroska clusters incrementally as opposed to all at once. (Closed)

Created:
9 years, 2 months ago by scherkus (not reviewing)

Modified:
9 years, 2 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, fgalligan1

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party

Visibility:
Public.

Description

Parse matroska clusters incrementally as opposed to all at once. While the patch is ugly, it prevents us from downloading the entire first cluster during the call to av_find_stream_info(). As a result, start up latency is greatly improved. BUG=100439 TEST=start up time, seeking, everything works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105638

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+263 lines, -6 lines)			Patch
M	ffmpeg/patches/README	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	ffmpeg/patches/ugly/41_matroska_cluster_incremental.patch	View	1 chunk	+163 lines, -0 lines	0 comments	Download
M	ffmpeg/source/patched-ffmpeg/libavformat/matroskadec.c	View	8 chunks	+97 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

9 years, 2 months ago (2011-10-15 03:50:06 UTC) #1

As discussed internally -- this patch is LGTM

TBR=acolwell, fgalligan

Expand Messages | Collapse Messages