chromeos: Implement the new D-Bus client for SessionManagerClient.

chrome/browser/chromeos/dbus/session_manager_client.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_DBUS_SESSION_MANAGER_CLIENT_H_
+#define CHROME_BROWSER_CHROMEOS_DBUS_SESSION_MANAGER_CLIENT_H_
+
+#include "base/callback.h"
+#include "base/observer_list.h"
+
+#include <string>
+
+namespace dbus {
+class Bus;
+}  // namespace
+
+namespace chromeos {
+
+// SessionManagerClient is used to communicate with the session manager.
+class SessionManagerClient {
+ public:
+  // Interface for observing changes from the session manager.
+  class Observer {
+   public:
+    // Called when the owner key is set.
+    virtual void OwnerKeySet(bool success) {}
+    // Called when the property change is complete.
+    virtual void PropertyChangeComplete(bool success) {}
+  };
+
+  // Adds and removes the observer.
+  virtual void AddObserver(Observer* observer) = 0;
+  virtual void RemoveObserver(Observer* observer) = 0;
+
+  // Kicks off an attempt to emit the "login-prompt-ready" upstart signal.
+  virtual void EmitLoginPromptReady() = 0;
+
+  // Kicks off an attempt to emit the "login-prompt-visible" upstart signal.
+  virtual void EmitLoginPromptVisible() = 0;
+
+  // Restarts a job referenced by |pid| with the provided command line.
+  virtual void RestartJob(int pid, const std::string& command_line) = 0;
+
+  // Restarts entd (the enterprise daemon).
+  virtual void RestartEntd() = 0;

[Chris Masone, 2011/10/18 16:32:41]

This is deprecated; we can either remove it now, or just note with a comment,
your choice.

[satorux1, 2011/10/18 17:49:44]

RestartEntd() is called from browser/chromeos/enterprise_extension_observer.cc.
Can we remove this code now?

For now, added a comment saying it's deprecated.

[Chris Masone, 2011/10/18 17:55:44]

I believe so, but kmixter and rginda would know for sure.  That can certainly
happen in a follow on CL, if it's appropriate.  I know that entd is no longer
running by default in R16, but it's still installed in case we need to backtrack
for some reason.  Perhaps we should leave it in til the Chromium R16 branch
point, if that hasn't happened already.
works for me!

+
+  // Starts the session for the user.
+  virtual void StartSession(const std::string& user_email) = 0;
+
+  // Stops the current session.
+  virtual void StopSession() = 0;
+
+  // Used for RetrievePolicy. Takes a serialized protocol buffer as string.
+  typedef base::Callback<void(const std::string&)> RetrievePolicyCallback;
+
+  // Fetches the policy blob stored by the session manager.  Upon
+  // completion of the retrieve attempt, we will call the provided
+  // callback.  Policies are serialized protocol buffers.  Upon success,
+  // we will pass a protobuf to the callback.  On failure, we will pass
+  // NULL.
+  virtual void RetrievePolicy(RetrievePolicyCallback callback) = 0;

[Chris Masone, 2011/10/18 16:32:41]

When I wrote this originally, davemoore indicated that he felt it shouldn't be
called RetrievePolicy, because it doesn't actually retrieve the policy :-)  It
asynchronously kicks off a request to retrieve the policy, and expects a
callback to fire upon success/failure.

That's why we settled on RequestRetrievePolicy.  We weren't super happy with the
name, but we felt it was more accurate.  If naming all asynchronous calls thusly
is a convention you're following in all this new code, that's fine.

[satorux1, 2011/10/18 17:49:44]

Good point. I expect all D-Bus method calls to be asynchronous in the D-Bus code
in Chrome, so I thought we wouldn't need to add something like 'Request' for
asynchronous methods. Otherwise, all method names end up starting with
'Request'. :)

[Chris Masone, 2011/10/18 17:55:44]

Fair enough

+
+  // Used for StorePolicyCallback. Takes a bollean indicating whether the

[Chris Masone, 2011/10/18 16:32:41]

nit: boolean

[satorux1, 2011/10/18 17:49:44]

Done.

+  // operation was successful or not.
+  typedef base::Callback<void(bool)> StorePolicyCallback;
+
+  // Attempts to store the policy blob |policy_blob| asynchronously.
+  // Upon completion of the store attempt, we will call callback(delegate, ...)
+  virtual void StorePolicy(const std::string& policy_bob,

[Chris Masone, 2011/10/18 16:32:41]

Same comment as above.

[satorux1, 2011/10/18 17:49:44]

Done.

+                           StorePolicyCallback callback) = 0;
+
+  // Creates the instance.
+  static SessionManagerClient* Create(dbus::Bus* bus);
+
+  virtual ~SessionManagerClient();
+
+ protected:
+  // Create() should be used instead.
+  SessionManagerClient();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(SessionManagerClient);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_DBUS_SESSION_MANAGER_CLIENT_H_