Chromium Code Reviews| Index: views/controls/textfield/native_textfield_views.cc |
| diff --git a/views/controls/textfield/native_textfield_views.cc b/views/controls/textfield/native_textfield_views.cc |
| index d2fbb143179bdf44fa776d04f4d2e91639428127..19221c68b440f1af0b557041dce857804c513839 100644 |
| --- a/views/controls/textfield/native_textfield_views.cc |
| +++ b/views/controls/textfield/native_textfield_views.cc |
| @@ -791,11 +791,11 @@ bool NativeTextfieldViews::DeleteRange(const ui::Range& range) { |
| bool NativeTextfieldViews::GetTextFromRange( |
| const ui::Range& range, |
| - const base::Callback<void(const string16&)>& callback) { |
| - if (GetTextInputType() != ui::TEXT_INPUT_TYPE_TEXT || range.is_empty()) |
| + string16* text) { |
| + if (GetTextInputType() != ui::TEXT_INPUT_TYPE_TEXT || !range.IsValid()) |
| return false; |
| - callback.Run(model_->GetTextFromRange(range)); |
| + *text = model_->GetTextFromRange(range); |
|
James Su
2011/10/28 04:20:45
You need to make sure the range is inside the cont
Peng
2011/10/28 15:42:19
Done.
|
| return true; |
| } |