Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4597)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_views.h

Issue 8294026: Support IMM32 reconversion on Windows (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix review issues Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view_views.h
diff --git a/chrome/browser/renderer_host/render_widget_host_view_views.h b/chrome/browser/renderer_host/render_widget_host_view_views.h
index 05ba1f7cb6528bcd0eb7a32cbfd8a0f83c6fc4e3..04e4309d5e1db97955657383f0cae9cc5d463e42 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_views.h
+++ b/chrome/browser/renderer_host/render_widget_host_view_views.h
@@ -92,7 +92,7 @@ class RenderWidgetHostViewViews : public RenderWidgetHostView,
virtual void SetTooltipText(const string16& tooltip_text) OVERRIDE;
virtual void SelectionChanged(const string16& text,
size_t offset,
- const ui::Range& range) OVERRIDE;
+ const ui::Range& range) OVRERRIDE;
Hironori Bono 2011/10/26 02:39:37 nit: OVRERRIDE -> OVERRIDE?
Peng 2011/10/26 16:20:16 Done.
virtual void SelectionBoundsChanged(const gfx::Rect& start_rect,
const gfx::Rect& end_rect) OVERRIDE;
virtual void ShowingContextMenu(bool showing) OVERRIDE;
@@ -178,7 +178,8 @@ class RenderWidgetHostViewViews : public RenderWidgetHostView,
virtual bool DeleteRange(const ui::Range& range) OVERRIDE;
virtual bool GetTextFromRange(
const ui::Range& range,
- const base::Callback<void(const string16&)>& callback) OVERRIDE;
+ string16* text,
+ ui::Range* actual_range) OVERRIDE;
virtual void OnInputMethodChanged() OVERRIDE;
virtual bool ChangeTextDirectionAndLayoutAlignment(
base::i18n::TextDirection direction) OVERRIDE;
@@ -289,9 +290,7 @@ class RenderWidgetHostViewViews : public RenderWidgetHostView,
// The current text input type.
ui::TextInputType text_input_type_;
- string16 selection_text_;
- size_t selection_text_offset_;
- ui::Range selection_range_;
+ // Rectangles before and after the selection.
gfx::Rect selection_start_rect_;
gfx::Rect selection_end_rect_;

Powered by Google App Engine
This is Rietveld 408576698