views/ime/text_input_client.h - Issue 8294026: Support IMM32 reconversion on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/ime/text_input_client.h

Issue 8294026: Support IMM32 reconversion on Windows (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix review issues Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/ime/text_input_client.h

diff --git a/views/ime/text_input_client.h b/views/ime/text_input_client.h

index 35c595fc19718790945460d4eb5dcb5e866aaadf..3c25cad3e7d1eac3d385c305bda7c8e2dc3f4f3a 100644

--- a/views/ime/text_input_client.h

+++ b/views/ime/text_input_client.h

@@ -98,12 +98,12 @@ class VIEWS_EXPORT TextInputClient {

virtual bool DeleteRange(const ui::Range& range) = 0;

// Retrieves the text content in a given UTF-16 based character range.

- // The result will be send back to the input method by calling the given

- // callback, which may happen asynchronously.

+ // The result will be write in text and actual_range.

James Su 2011/10/25 19:15:03 nit: write in -> written into And please explain t

Peng 2011/10/25 22:01:21 Done.

// Returns false if the operation is not supported.

virtual bool GetTextFromRange(

const ui::Range& range,

- const base::Callback<void(const string16&)>& callback) = 0;

+ string16* text,

+ ui::Range* actual_range) = 0;

// Miscellaneous ------------------------------------------------------------

« no previous file with comments | « views/ime/input_method_win.cc ('k') | views/widget/native_widget_win.h » ('j') | no next file with comments »