Support IMM32 reconversion on Windows

chrome/browser/renderer_host/render_widget_host_view_views.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_VIEWS_H_
 #define CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_VIEWS_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 160 matching lines @@
   virtual ui::TextInputType GetTextInputType() const OVERRIDE;
   virtual gfx::Rect GetCaretBounds() OVERRIDE;
   virtual bool HasCompositionText() OVERRIDE;
   virtual bool GetTextRange(ui::Range* range) OVERRIDE;
   virtual bool GetCompositionTextRange(ui::Range* range) OVERRIDE;
   virtual bool GetSelectionRange(ui::Range* range) OVERRIDE;
   virtual bool SetSelectionRange(const ui::Range& range) OVERRIDE;
   virtual bool DeleteRange(const ui::Range& range) OVERRIDE;
   virtual bool GetTextFromRange(
       const ui::Range& range,
-      const base::Callback<void(const string16&)>& callback) OVERRIDE;
+      string16* text,
+      ui::Range* actual_range) OVERRIDE;
   virtual void OnInputMethodChanged() OVERRIDE;
   virtual bool ChangeTextDirectionAndLayoutAlignment(
       base::i18n::TextDirection direction) OVERRIDE;
   virtual views::View* GetOwnerViewOfTextInputClient() OVERRIDE;
 
 #if defined(UI_COMPOSITOR_IMAGE_TRANSPORT)
   virtual void AcceleratedSurfaceNew(
       int32 width,
       int32 height,
       uint64* surface_id,
@@ skipping 94 matching lines @@
   // removed from the list on an ET_TOUCH_RELEASED event.
   WebKit::WebTouchEvent touch_event_;
 
   // The current text input type.
   ui::TextInputType text_input_type_;
 
   string16 selection_text_;
   size_t selection_text_offset_;
   ui::Range selection_range_;
   gfx::Rect selection_start_rect_;
   gfx::Rect selection_end_rect_;

[James Su, 2011/10/25 19:15:03]

Can you please add some comment describing the meaning of these selection
related variables? Especially selection_text_*_.

And looks like we can extract some common selection related code into
RenderWidgetHostView, please help look into it.

[Peng, 2011/10/25 22:01:21]

Done.

 
   // Indicates if there is onging composition text.
   bool has_composition_text_;
 
   string16 tooltip_text_;
 
 #if defined(UI_COMPOSITOR_IMAGE_TRANSPORT)
   std::vector< base::Callback<void(void)> > on_compositing_ended_callbacks_;
 #endif
 
   scoped_ptr<views::TouchSelectionController> touch_selection_controller_;
   ScopedRunnableMethodFactory<RenderWidgetHostViewViews>
       update_touch_selection_;
 
 #if defined(TOUCH_UI)
   // used to register for keyboard visiblity notificatons.
   content::NotificationRegistrar registrar_;
   gfx::Rect keyboard_rect_;
 #endif
 
 #if defined(UI_COMPOSITOR_IMAGE_TRANSPORT)
   std::map<uint64, scoped_refptr<AcceleratedSurfaceContainerLinux> >
       accelerated_surface_containers_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewViews);
 };
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_VIEWS_H_