base::Bind: Convert FileUtilProxy::ReadCallback.

base::Bind: Convert FileUtilProxy::ReadCallback.

BUG=none
TEST=none

R=csilv@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105905

[csilv, 2011-10-17 19:46:16]

http://codereview.chromium.org/8294015/diff/1/base/file_util_proxy.h
File base/file_util_proxy.h (right):

http://codereview.chromium.org/8294015/diff/1/base/file_util_proxy.h#newcode164
base/file_util_proxy.h:164: // |offset + bytes_to_read| in the file. The
callback can be NULL.
Technically the callback can't be NULL.... so mybe we want to re-word the
comment?  Or maybe the general gist of the comment is still accurate.

[James Hawkins, 2011-10-17 20:10:17]

http://codereview.chromium.org/8294015/diff/1/base/file_util_proxy.h
File base/file_util_proxy.h (right):

http://codereview.chromium.org/8294015/diff/1/base/file_util_proxy.h#newcode164
base/file_util_proxy.h:164: // |offset + bytes_to_read| in the file. The
callback can be NULL.
On 2011/10/17 19:46:16, csilv wrote:
> Technically the callback can't be NULL.... so mybe we want to re-word the
> comment?  Or maybe the general gist of the comment is still accurate.

Changed it to read "null".

[csilv, 2011-10-17 20:22:28]

LGTM with comment nits.

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h
File base/file_util_proxy.h (right):

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:36: // valid to pass NULL as the callback parameter to
any function that takes a
"valid to pass a null callback"

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:61: // Creates or opens a file with the given flags.  It
is invalid to pass NULL
NULL -> null

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:73: // are returned.  It is invalid to pass NULL for the
callback.  The additional
NULL -> null

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:104: // Retrieves the information about a file. It is
invalid to pass NULL for the
NULL -> null

[James Hawkins, 2011-10-17 20:44:38]

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h
File base/file_util_proxy.h (right):

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:36: // valid to pass NULL as the callback parameter to
any function that takes a
On 2011/10/17 20:22:28, csilv wrote:
> "valid to pass a null callback"

This is fixed in the StatusCallback CL.

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:61: // Creates or opens a file with the given flags.  It
is invalid to pass NULL
On 2011/10/17 20:22:28, csilv wrote:
> NULL -> null

Done.

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:73: // are returned.  It is invalid to pass NULL for the
callback.  The additional
On 2011/10/17 20:22:28, csilv wrote:
> NULL -> null

Done.

http://codereview.chromium.org/8294015/diff/1004/base/file_util_proxy.h#newco...
base/file_util_proxy.h:104: // Retrieves the information about a file. It is
invalid to pass NULL for the
On 2011/10/17 20:22:28, csilv wrote:
> NULL -> null

Done.