Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 8294007: Get rid of view_messages.h includes in chrome\renderer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_histograms.cc
===================================================================
--- chrome/renderer/page_load_histograms.cc (revision 105613)
+++ chrome/renderer/page_load_histograms.cc (working copy)
@@ -12,7 +12,6 @@
#include "chrome/common/extensions/url_pattern.h"
#include "chrome/renderer/prerender/prerender_helper.h"
#include "chrome/renderer/renderer_histogram_snapshots.h"
-#include "content/common/view_messages.h"
#include "content/public/renderer/navigation_state.h"
#include "content/public/renderer/render_view.h"
#include "googleurl/src/gurl.h"
@@ -777,15 +776,12 @@
Dump(frame);
}
-bool PageLoadHistograms::OnMessageReceived(const IPC::Message& message) {
- if (message.type() == ViewMsg_ClosePage::ID) {
- // TODO(davemoore) This code should be removed once willClose() gets
- // called when a page is destroyed. page_load_histograms_.Dump() is safe
- // to call multiple times for the same frame, but it will simplify things.
- Dump(render_view()->GetWebView()->mainFrame());
- ResetCrossFramePropertyAccess();
- }
- return false;
+void PageLoadHistograms::ClosePage() {
+ // TODO(davemoore) This code should be removed once willClose() gets
+ // called when a page is destroyed. page_load_histograms_.Dump() is safe
+ // to call multiple times for the same frame, but it will simplify things.
+ Dump(render_view()->GetWebView()->mainFrame());
+ ResetCrossFramePropertyAccess();
}
void PageLoadHistograms::LogPageLoadTime(const NavigationState* state,

Powered by Google App Engine
This is Rietveld 408576698