Issue 8294007: Get rid of view_messages.h includes in chrome\renderer.

Issue 8294007: Get rid of view_messages.h includes in chrome\renderer. (Closed)

Created:
9 years, 2 months ago by jam

Modified:
9 years, 2 months ago

Reviewers:
ananta

CC:
chromium-reviews, Erik does not do reviews, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get rid of view_messages.h includes in chrome\renderer. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105666

Patch Set 1 : '' #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -46 lines)			Patch
M	chrome/renderer/blocked_plugin.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/chrome_render_process_observer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/content_settings_observer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_extension_handler.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/renderer/frame_sniffer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/page_click_tracker.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/renderer/page_click_tracker.cc	View	2 chunks	+0 lines, -16 lines	2 comments	Download
M	chrome/renderer/page_load_histograms.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/page_load_histograms.cc	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	content/public/renderer/render_thread.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/renderer/render_view_observer.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/test/mock_render_thread.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/test/mock_render_thread.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ananta

LGTM http://codereview.chromium.org/8294007/diff/7002/chrome/renderer/page_click_tracker.cc File chrome/renderer/page_click_tracker.cc (left): http://codereview.chromium.org/8294007/diff/7002/chrome/renderer/page_click_tracker.cc#oldcode96 chrome/renderer/page_click_tracker.cc:96: if (message.type() == ViewMsg_HandleInputEvent::ID) { This code not ...

9 years, 2 months ago (2011-10-15 00:15:21 UTC) #2

jam

9 years, 2 months ago (2011-10-15 00:17:10 UTC) #3

http://codereview.chromium.org/8294007/diff/7002/chrome/renderer/page_click_t...
File chrome/renderer/page_click_tracker.cc (left):

http://codereview.chromium.org/8294007/diff/7002/chrome/renderer/page_click_t...
chrome/renderer/page_click_tracker.cc:96: if (message.type() ==
ViewMsg_HandleInputEvent::ID) {
On 2011/10/15 00:15:21, ananta wrote:
> This code not needed anymore?

yeah, i don't know why it got checked in like that (in
http://codereview.chromium.org/6151011). I think I may have started making it
filter IPCs, then I decided to add a DidHandleMouseEvent callback in RVO but
didn't take out this code.

Expand Messages | Collapse Messages