PPAPI Fullscreen: move out of Dev.

webkit/plugins/ppapi/plugin_module.cc

Index: webkit/plugins/ppapi/plugin_module.cc
===================================================================
--- webkit/plugins/ppapi/plugin_module.cc	(revision 105485)
+++ webkit/plugins/ppapi/plugin_module.cc	(working copy)
@@ -51,6 +51,7 @@
 #include "ppapi/c/ppb_file_io.h"
 #include "ppapi/c/ppb_file_ref.h"
 #include "ppapi/c/ppb_file_system.h"
+#include "ppapi/c/ppb_fullscreen.h"
 #include "ppapi/c/ppb_graphics_2d.h"
 #include "ppapi/c/ppb_graphics_3d.h"
 #include "ppapi/c/ppb_image_data.h"
@@ -275,6 +276,8 @@
     return ::ppapi::thunk::GetPPB_Flash_UDPSocket_Thunk();
   if (strcmp(name, PPB_FULLSCREEN_DEV_INTERFACE_0_4) == 0)
     return ::ppapi::thunk::GetPPB_FlashFullscreen_Thunk();
+  if (strcmp(name, PPB_FULLSCREEN_DEV_INTERFACE_0_5) == 0)

[dmichael (off chromium), 2011/10/14 15:20:55]

Why not PPB_FULLSCREEN_INTERFACE or PPB_FULLSCREEN_INTERFACE_1_0? I'm confused;
I'm not sure where this definition came from.

[polina, 2011/10/14 19:15:04]

I guess I just copied the one right above it.
Sure I can change it to PPB_FULLSCREEN_DEV_INTERFACE.

[dmichael(do not use this one), 2011/10/14 19:23:00]

What's the intent? I thought you were trying to add the new 'non-dev' interface
here... so it's mainly the 'DEV' part I'm questioning. Did I misunderstand?

[polina, 2011/10/14 19:24:48]

The intent is to be backwards-compatible in case there are some demo apps or
something that use PPB_Fullscreen_Dev. I was going to take this out and the old
header next week.

+    return ::ppapi::thunk::GetPPB_Fullscreen_Thunk();
   if (strcmp(name, PPB_GPU_BLACKLIST_INTERFACE) == 0)
     return PPB_GpuBlacklist_Private_Impl::GetInterface();
   if (strcmp(name, PPB_GRAPHICS_3D_TRUSTED_INTERFACE) == 0)