PPAPI Fullscreen: move out of Dev.

PPAPI Fullscreen: move out of Dev.

BUG=41780
TEST=in CL
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105590

[dmichael (off chromium), 2011-10-14 15:20:54]

a couple of nits, one bit that confused me... o/w LGTM

By the way, nice test!

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc
(right):

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc:9:
#include "ppapi/c/ppb_fullscreen.h"
nit: this is out of order now

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
File ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.cc
(right):

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.cc:8: #include
"ppapi/c/ppb_fullscreen.h"
nit: include order

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
webkit/plugins/ppapi/plugin_module.cc:279: if (strcmp(name,
PPB_FULLSCREEN_DEV_INTERFACE_0_5) == 0)
Why not PPB_FULLSCREEN_INTERFACE or PPB_FULLSCREEN_INTERFACE_1_0? I'm confused;
I'm not sure where this definition came from.

[polina, 2011-10-14 19:15:04]

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc
(right):

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_fullscreen_rpc_server.cc:9:
#include "ppapi/c/ppb_fullscreen.h"
On 2011/10/14 15:20:55, dmichael wrote:
> nit: this is out of order now

Done.

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
File ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.cc
(right):

http://codereview.chromium.org/8291002/diff/5034/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.cc:8: #include
"ppapi/c/ppb_fullscreen.h"
On 2011/10/14 15:20:55, dmichael wrote:
> nit: include order

Done.

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
webkit/plugins/ppapi/plugin_module.cc:279: if (strcmp(name,
PPB_FULLSCREEN_DEV_INTERFACE_0_5) == 0)
On 2011/10/14 15:20:55, dmichael wrote:
> Why not PPB_FULLSCREEN_INTERFACE or PPB_FULLSCREEN_INTERFACE_1_0? I'm
confused;
> I'm not sure where this definition came from.

I guess I just copied the one right above it.
Sure I can change it to PPB_FULLSCREEN_DEV_INTERFACE.

[dmichael(do not use this one), 2011-10-14 19:23:00]

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
webkit/plugins/ppapi/plugin_module.cc:279: if (strcmp(name,
PPB_FULLSCREEN_DEV_INTERFACE_0_5) == 0)
On 2011/10/14 19:15:04, polina wrote:
> On 2011/10/14 15:20:55, dmichael wrote:
> > Why not PPB_FULLSCREEN_INTERFACE or PPB_FULLSCREEN_INTERFACE_1_0? I'm
> confused;
> > I'm not sure where this definition came from.
> 
> I guess I just copied the one right above it.
> Sure I can change it to PPB_FULLSCREEN_DEV_INTERFACE.
What's the intent? I thought you were trying to add the new 'non-dev' interface
here... so it's mainly the 'DEV' part I'm questioning. Did I misunderstand?

[polina, 2011-10-14 19:24:48]

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/8291002/diff/5034/webkit/plugins/ppapi/plugin_...
webkit/plugins/ppapi/plugin_module.cc:279: if (strcmp(name,
PPB_FULLSCREEN_DEV_INTERFACE_0_5) == 0)
On 2011/10/14 19:23:00, dmichael(do not use this one) wrote:
> On 2011/10/14 19:15:04, polina wrote:
> > On 2011/10/14 15:20:55, dmichael wrote:
> > > Why not PPB_FULLSCREEN_INTERFACE or PPB_FULLSCREEN_INTERFACE_1_0? I'm
> > confused;
> > > I'm not sure where this definition came from.
> > 
> > I guess I just copied the one right above it.
> > Sure I can change it to PPB_FULLSCREEN_DEV_INTERFACE.
> What's the intent? I thought you were trying to add the new 'non-dev'
interface
> here... so it's mainly the 'DEV' part I'm questioning. Did I misunderstand?

The intent is to be backwards-compatible in case there are some demo apps or
something that use PPB_Fullscreen_Dev. I was going to take this out and the old
header next week.

[dmichael (off chromium), 2011-10-14 19:27:20]

I see, thanks for explaining. In that case, I'm fine with it either way. I
forgot that the new interface is handled above there in that function by Brett's
new macro magic, so got confused when I saw an interface other than the one I
expected to see there.

still LGTM :-)

[polina, 2011-10-14 22:05:46]

Committed revision 105590.