Issue 8290001: Excludes printing aura files on windows as the windows ones work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8290001: Excludes printing aura files on windows as the windows ones work (Closed)

Created:
9 years, 2 months ago by sky

Modified:
9 years, 2 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Excludes printing aura files on windows as the windows ones work fine. BUG=none TEST=none R=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105411

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

		Unified diffs	Side-by-side diffs	Stats (+9 lines, -0 lines)
	M	printing/printing.gyp	View	1 chunk	+9 lines, -0 lines	1 comment

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

9 years, 2 months ago (2011-10-13 21:51:44 UTC) #2

LGTM

http://codereview.chromium.org/8290001/diff/1/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/8290001/diff/1/printing/printing.gyp#newcode126
printing/printing.gyp:126: 'printed_document_aura.cc',
nit: printed before printing.

Expand Messages | Collapse Messages