Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: net/base/cookie_monster_store_test.cc

Issue 8289028: Revert 105639 - The change list splits loading of cookies from DB by the domain key(eTLD+1). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/cookie_monster_store_test.h ('k') | net/base/cookie_monster_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/cookie_monster_store_test.cc
===================================================================
--- net/base/cookie_monster_store_test.cc (revision 105639)
+++ net/base/cookie_monster_store_test.cc (working copy)
@@ -4,7 +4,6 @@
#include "net/base/cookie_monster_store_test.h"
-#include "base/bind.h"
#include "base/message_loop.h"
#include "base/stringprintf.h"
#include "base/time.h"
@@ -12,17 +11,9 @@
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
-LoadedCallbackTask::LoadedCallbackTask(LoadedCallback loaded_callback,
- std::vector<CookieMonster::CanonicalCookie*> cookies)
- : loaded_callback_(loaded_callback),
- cookies_(cookies) {
-}
-LoadedCallbackTask::~LoadedCallbackTask() {}
-
MockPersistentCookieStore::MockPersistentCookieStore()
- : load_return_value_(true),
- loaded_(false) {
+ : load_return_value_(true) {
}
MockPersistentCookieStore::~MockPersistentCookieStore() {}
@@ -34,29 +25,16 @@
load_result_ = result;
}
-void MockPersistentCookieStore::Load(const LoadedCallback& loaded_callback) {
+bool MockPersistentCookieStore::Load(const LoadedCallback& loaded_callback) {
+ bool ok = load_return_value_;
std::vector<CookieMonster::CanonicalCookie*> out_cookies;
- if (load_return_value_) {
+ if (ok) {
out_cookies = load_result_;
- loaded_ = true;
}
- MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(&LoadedCallbackTask::Run,
- new LoadedCallbackTask(loaded_callback, out_cookies)));
+ loaded_callback.Run(out_cookies);
+ return ok;
}
-void MockPersistentCookieStore::LoadCookiesForKey(const std::string& key,
- const LoadedCallback& loaded_callback) {
- if (!loaded_) {
- Load(loaded_callback);
- } else {
- MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(&LoadedCallbackTask::Run,
- new LoadedCallbackTask(loaded_callback,
- std::vector<CookieMonster::CanonicalCookie*>())));
- }
-}
-
void MockPersistentCookieStore::AddCookie(
const CookieMonster::CanonicalCookie& cookie) {
commands_.push_back(
@@ -135,38 +113,21 @@
!cookie_expires.is_null());
}
-MockSimplePersistentCookieStore::MockSimplePersistentCookieStore()
- : loaded_(false) {}
+MockSimplePersistentCookieStore::MockSimplePersistentCookieStore() {}
MockSimplePersistentCookieStore::~MockSimplePersistentCookieStore() {}
-void MockSimplePersistentCookieStore::Load(
+bool MockSimplePersistentCookieStore::Load(
const LoadedCallback& loaded_callback) {
std::vector<CookieMonster::CanonicalCookie*> out_cookies;
-
for (CanonicalCookieMap::const_iterator it = cookies_.begin();
it != cookies_.end(); it++)
out_cookies.push_back(
new CookieMonster::CanonicalCookie(it->second));
-
- MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(&LoadedCallbackTask::Run,
- new LoadedCallbackTask(loaded_callback, out_cookies)));
- loaded_ = true;
+ loaded_callback.Run(out_cookies);
+ return true;
}
-void MockSimplePersistentCookieStore::LoadCookiesForKey(const std::string& key,
- const LoadedCallback& loaded_callback) {
- if (!loaded_) {
- Load(loaded_callback);
- } else {
- MessageLoop::current()->PostTask(FROM_HERE,
- base::Bind(&LoadedCallbackTask::Run,
- new LoadedCallbackTask(loaded_callback,
- std::vector<CookieMonster::CanonicalCookie*>())));
- }
-}
-
void MockSimplePersistentCookieStore::AddCookie(
const CookieMonster::CanonicalCookie& cookie) {
int64 creation_time = cookie.CreationDate().ToInternalValue();
« no previous file with comments | « net/base/cookie_monster_store_test.h ('k') | net/base/cookie_monster_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698