runtime/vm/code_generator_ia32.cc - Issue 8289027: Set type argument vector at compile time in type of closure parameters; this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8289027: Set type argument vector at compile time in type of closure parameters; this (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_ia32.cc

===================================================================

--- runtime/vm/code_generator_ia32.cc (revision 478)

+++ runtime/vm/code_generator_ia32.cc (working copy)

@@ -1385,6 +1385,7 @@

void CodeGenerator::GenerateInstanceOf(intptr_t token_index,

const Type& type,

bool negate_result) {

+ ASSERT(type.IsFinalized());

const Bool& bool_true = Bool::ZoneHandle(Bool::True());

const Bool& bool_false = Bool::ZoneHandle(Bool::False());

@@ -1504,7 +1505,7 @@

ASSERT(FLAG_enable_type_checks);

ASSERT(token_index >= 0);

ASSERT(!dst_type.IsNull());

- ASSERT(dst_type.IsResolved());

+ ASSERT(dst_type.IsFinalized());

// Any expression is assignable to the VarType. Skip the test.

if (dst_type.IsVarType()) {

« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »