Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 8289027: Set type argument vector at compile time in type of closure parameters; this (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator_ia32.cc » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 463)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -438,7 +438,7 @@
ParameterizedType& parameterized_type = ParameterizedType::Handle();
parameterized_type ^= type.raw();
- if (parameterized_type.is_being_finalized()) {
+ if (parameterized_type.IsBeingFinalized()) {
ReportError("type '%s' illegally refers to itself\n",
String::Handle(parameterized_type.Name()).ToCString());
}
@@ -540,11 +540,11 @@
function.set_result_type(type);
FinalizeType(type);
// Resolve formal parameter types.
- intptr_t num_parameters = function.NumberOfParameters();
- for (intptr_t p = 0; p < num_parameters; p++) {
- type = function.ParameterTypeAt(p);
+ const intptr_t num_parameters = function.NumberOfParameters();
+ for (intptr_t i = 0; i < num_parameters; i++) {
+ type = function.ParameterTypeAt(i);
type = ResolveType(cls, type);
- function.SetParameterTypeAt(p, type);
+ function.SetParameterTypeAt(i, type);
FinalizeType(type);
}
}
@@ -642,10 +642,10 @@
}
}
}
- // Resolve type of signature function.
+ // Resolve the signature type if this class is a signature class.
if (cls.IsSignatureClass()) {
- ResolveAndFinalizeSignature(cls,
- Function::Handle(cls.signature_function()));
+ const Type& signature_type = Type::Handle(cls.SignatureType());
+ FinalizeType(signature_type);
}
}
« no previous file with comments | « no previous file | runtime/vm/code_generator_ia32.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698