chrome/browser/sync/profile_sync_service_typed_url_unittest.cc - Issue 8289026: Correctly handle expired and truncated visits in typed url sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

Issue 8289026: Correctly handle expired and truncated visits in typed url sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed a bunch of debug statements/unrelated test code Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

index 715f8d74c08e67c5d9c3dada415f3f6bd0baaeeb..bda65ee7f57a3e4df8922f98351b821c7bb76d80 100644

--- a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

@@ -267,8 +267,10 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest {

int64 last_visit,

bool hidden,

history::VisitVector* visits) {

+ // Give each URL a unique ID, to mimic the behavior of the real database.

+ static int unique_url_id = 0;

GURL gurl(url);

- URLRow history_url(gurl);

+ URLRow history_url(gurl, ++unique_url_id);

history_url.set_title(UTF8ToUTF16(title));

history_url.set_typed_count(typed_count);

history_url.set_last_visit(