Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc

Issue 8289026: Correctly handle expired and truncated visits in typed url sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed compilation error. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
index 715f8d74c08e67c5d9c3dada415f3f6bd0baaeeb..bda65ee7f57a3e4df8922f98351b821c7bb76d80 100644
--- a/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
@@ -267,8 +267,10 @@ class ProfileSyncServiceTypedUrlTest : public AbstractProfileSyncServiceTest {
int64 last_visit,
bool hidden,
history::VisitVector* visits) {
+ // Give each URL a unique ID, to mimic the behavior of the real database.
+ static int unique_url_id = 0;
GURL gurl(url);
- URLRow history_url(gurl);
+ URLRow history_url(gurl, ++unique_url_id);
history_url.set_title(UTF8ToUTF16(title));
history_url.set_typed_count(typed_count);
history_url.set_last_visit(
« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698