Issue 8289022: Wires keeping the launcher up to date with the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8289022: Wires keeping the launcher up to date with the browser. (Closed)

Created:
9 years, 2 months ago by sky

Modified:
9 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, dhollowa, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Wires keeping the launcher up to date with the browser. I also needed GetBrowserViewForNativeWindow, so I had to wire up ViewProps for it to work correctly. BUG=97262 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105677

Patch Set 1 #

Patch Set 2 : Tweaks #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+391 lines, -35 lines)			Patch
M	build/common.gypi	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
A	chrome/browser/ui/aura/chrome_shell_delegate.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/aura/chrome_shell_delegate.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/aura/launcher_icon_updater.h	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/aura/launcher_icon_updater.cc	View		1 chunk	+109 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View		4 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		4 chunks	+19 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/window.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura/window_observer.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.h	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher.cc	View	1	1 chunk	+28 lines, -9 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_model.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_model.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	ui/aura_shell/launcher/launcher_view.cc	View		1 chunk	+12 lines, -1 line	0 comments	Download
M	ui/gfx/compositor/layer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/ui.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_aura.h	View		4 chunks	+8 lines, -6 lines	0 comments	Download
M	views/widget/native_widget_aura.cc	View		4 chunks	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 2 months ago (2011-10-15 01:00:47 UTC) #2

LGTM

I think you should push the browser/ui/aura files down into
browser/ui/views/aura... the dirs in browser/ui/ are supposed to be components
in the component build sense, but browser/ui/aura would probably end up with a
circular dependency on browser/ui/views.

Expand Messages | Collapse Messages