Issue 8289006: Add support for goma-clang to make builds, switch macmake fyi bot over.

Issue 8289006: Add support for goma-clang to make builds, switch macmake fyi bot over. (Closed)

Created:
9 years, 2 months ago by Nico

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, szager, M-A Ruel, szager1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

Description

Add support for goma-clang to make builds, switch macmake fyi bot over. BUG=99427 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105562

Patch Set 3 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -11 lines)			Patch
	M	build/masters/master.chromium.fyi/master.cfg	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/scripts/slave/compile.py	View	1 2	4 chunks	+28 lines, -10 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

szager

http://codereview.chromium.org/8289006/diff/2001/build/scripts/slave/compile.py File build/scripts/slave/compile.py (right): http://codereview.chromium.org/8289006/diff/2001/build/scripts/slave/compile.py#newcode486 build/scripts/slave/compile.py:486: env['PATH'] = options.goma_dir + ':' + + clang_dir + ...

9 years, 2 months ago (2011-10-14 20:11:27 UTC) #3

Nico

Thanks! I also added an explicit GCC.host setting to make sure host files are built ...

9 years, 2 months ago (2011-10-14 20:16:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8289006/7001

9 years, 2 months ago (2011-10-14 20:22:52 UTC) #6

commit-bot: I haz the power

Presubmit check for 8289006-7001 failed and returned exit status 1. Running presubmit commit checks ...

9 years, 2 months ago (2011-10-14 20:24:19 UTC) #7

szager

9 years, 2 months ago (2011-10-14 20:31:03 UTC) #8

Grrr... I'll fix this.

On Fri, Oct 14, 2011 at 1:24 PM,  <commit-bot@chromium.org> wrote:
> Presubmit check for 8289006-7001 failed and returned exit status 1.
>
> Running presubmit commit checks ...
> ************* Module botmap
> F0401:  7,0: Unable to import 'chromium_utils'
>
> ** Presubmit ERRORS **
> Fix pylint errors first.
>
> Presubmit checks took 77.6s to calculate.
>
>
>
> http://codereview.chromium.org/8289006/
>

Expand Messages | Collapse Messages