Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 8286003: Create implicit super constructor call if necessary (Closed)

Created:
9 years, 2 months ago by hausner
Modified:
9 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create implicit super constructor call if necessary Create an implicit call to the super constructor if no explicit call is present, and also if the constructor does not have an initializer list at all. The evaluation order is still not conforming to the spec. Thus, a couple of tests that happened to pass before now fail. Fix issue 85 https://code.google.com/p/dart/issues/detail?id=85 Committed: https://code.google.com/p/dart/source/detail?r=412

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -98 lines) Patch
M runtime/vm/parser.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 2 3 4 10 chunks +102 lines, -94 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
9 years, 2 months ago (2011-10-13 18:55:46 UTC) #1
regis
LGTM http://codereview.chromium.org/8286003/diff/2003/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/8286003/diff/2003/runtime/vm/parser.cc#newcode1381 runtime/vm/parser.cc:1381: for (;;) { If you do not consume ...
9 years, 2 months ago (2011-10-13 19:32:29 UTC) #2
hausner
9 years, 2 months ago (2011-10-13 20:24:09 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698