Changes "is" and equality checks to strictly check for primitive types, fix a couple of

compiler/lib/implementation/string.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class StringImplementation implements String native "String" {
   factory StringImplementation.fromValues(Array<int> values) {
     return _newFromValues(values);
   }
 
   String operator[](int index) {
@@ skipping 127 matching lines @@
 
   Iterable<Match> allMatches(String str) {
     List<Match> result = [];
     if (this.isEmpty()) return result;
     int length = this.length;
 
     int ix = 0;
     while (ix < str.length) {
       int foundIx = str.indexOf(this, ix);
       if (foundIx < 0) break;
-      result.add(new _StringMatch(foundIx, str, this));
+      // call "toString" to coerse the "this" back to a primitive string

[floitsch, 2011/10/14 20:20:44]

Call ... coerce ... string. (finish with dot).

[John Lenz, 2011/10/14 21:26:40]

Done.

+      result.add(new _StringMatch(foundIx, str, this.toString()));
       ix = foundIx + length;
     }
     return result;
   }
 
   Array<String> splitChars() {
     return _split("");
   }
 
   Array<int> charCodes() {
@@ skipping 18 matching lines @@
 
   int compareTo(String other) native;
 
   static String _newFromValues(Array<int> values) native;
   String _indexOperator(int index) native;
   int _charCodeAt(int index) native;
   String _substringUnchecked(int startIndex, int endIndex) native;
   String _replace(Pattern from, String to) native;
   String _replaceAll(Pattern from, String to) native;
   Array<String> _split(Pattern pattern) native;
+
+  get dynamic() { return toString(); }
 }
 
 class _StringJsUtil {
   static String toDartString(o) native {
     if (o === null) return "null";
     return o.toString();
   }
 }
 
 class _StringMatch implements Match {
@@ skipping 18 matching lines @@
     for (int g in groups) {
       result.add(group(g));
     }
     return result;
   }
 
   final int _start;
   final String str;
   final String pattern;
 }