Changes "is" and equality checks to strictly check for primitive types, fix a couple of

compiler/lib/implementation/number.js

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 
 function native_NumberImplementation_BIT_OR(other) {
   return this | other;
 }
 
@@ skipping 66 matching lines @@
 
 function native_NumberImplementation_LTE(other) {
   return this <= other;
 }
 
 function native_NumberImplementation_GTE(other) {
   return this >= other;
 }
 
 function native_NumberImplementation_EQ(other) {
-  if (typeof other == 'number') {
-    return this == other;
-  } else if (other instanceof Number) {
-    // Must convert other to a primitive for value equality to work
-    return this == Number(other);
-  } else {
-    return false;
-  }
+  return typeof other == 'number' && this == other;

[floitsch, 2011/10/14 20:20:44]

Same as for booleans: operator$EQ should intercept and we should never arrive
here.
(again: another CL is fine).

[John Lenz, 2011/10/14 21:26:40]

It is already special cased in EQ$operator, but I'll leave this for now.

 }
 
 function native_NumberImplementation_BIT_NOT() {
   return ~this;
 }
 
 function native_NumberImplementation_negate() { return -this; }
 
 function native_NumberImplementation_remainder(other) {
   return this % other;
@@ skipping 12 matching lines @@
   if (this == 0) return (1 / this) < 0;
   return this < 0;
 }
 function native_NumberImplementation_isEven() { return ((this & 1) == 0); }
 function native_NumberImplementation_isOdd() { return ((this & 1) == 1); }
 function native_NumberImplementation_isNaN() { return isNaN(this); }
 function native_NumberImplementation_isInfinite() {
   return (this == Infinity) || (this == -Infinity);
 }
 
+function native_NumberImplementation_toDouble() {
+  return this.valueOf();
+}
+
 function native_NumberImplementation_toString() {
   return this.toString();
 }
 function native_NumberImplementation_toStringAsFixed(fractionDigits) {
   return this.toFixed(fractionDigits);
 }
 function native_NumberImplementation_toStringAsPrecision(precision) {
   return this.toPrecision(precision);
 }
 function native_NumberImplementation_toStringAsExponential(fractionDigits) {
   return this.toExponential(fractionDigits);
 }
 function native_NumberImplementation_toRadixString(radix) {
   return this.toString(radix);
 }
 
 function native_NumberImplementation_hashCode() {
   return this & 0xFFFFFFF;
 }