Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 8280002: PrintPreview: Added code to honor the grayscale color model. (Closed)

Created:
9 years, 2 months ago by kmadhusu
Modified:
9 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

PrintPreview: Added code to honor the grayscale color model. BUG=None TEST=Add a printer which supports grayscale and cmyk color models. Preview a color webpage. Observe that the color options is displayed to the user. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/printing/print_system_task_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/color_settings.js View 1 chunk +6 lines, -2 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kmadhusu
Fixed another test case :)
9 years, 2 months ago (2011-10-13 21:52:58 UTC) #1
vandebo (ex-Chrome)
LGTM
9 years, 2 months ago (2011-10-14 06:23:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/8280002/1
9 years, 2 months ago (2011-10-14 16:52:52 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-14 18:27:39 UTC) #4
Change committed as 105528

Powered by Google App Engine
This is Rietveld 408576698