Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 8277018: Move content_switches to content\public\common. (Closed)

Created:
9 years, 2 months ago by jam
Modified:
9 years, 2 months ago
Reviewers:
Jói
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc+watch_chromium.org, ajwong+watch_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com, Erik does not do reviews, acolwell+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, dpranke-watch+content_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move content_switches to content\public\common. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105389

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -785 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/relauncher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/magic_iframe_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_exe.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_broker_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_ppapi_interfaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/webgl_conformance_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/npapi_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browsing_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/device_orientation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/file_system/browser_file_system_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/file_system/file_system_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/core_location_provider_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/win7_location_api_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/webkit_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/intents/intent_injector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mach_broker_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/backing_store_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_host_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_main_linux.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/child_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/common/content_switches.h View 1 chunk +0 lines, -173 lines 0 comments Download
D content/common/content_switches.cc View 1 chunk +0 lines, -503 lines 0 comments Download
M content/common/debug_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/handle_enumerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/npobject_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/pepper_plugin_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_init_wrapper_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_init_wrapper_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/seccomp_sandbox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_broker_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/common/content_switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/common/content_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools_agent.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/devtools_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/shell/shell_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/utility/utility_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/webworkerclient_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/worker/worker_thread.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 2 months ago (2011-10-13 21:00:54 UTC) #1
Jói
LGTM On Thu, Oct 13, 2011 at 2:00 PM, <jam@chromium.org> wrote: > Reviewers: Jói, > ...
9 years, 2 months ago (2011-10-13 21:22:46 UTC) #2
Jói
9 years, 2 months ago (2011-10-13 21:22:48 UTC) #3
LGTM

On Thu, Oct 13, 2011 at 2:00 PM,  <jam@chromium.org> wrote:
> Reviewers: Jói,
>
> Description:
> Move content_switches to content\public\common.
>
> BUG=98716
>
> Please review this at http://codereview.chromium.org/8277018/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/app/chrome_main_delegate.cc
>  M     chrome/browser/about_flags.cc
>  M     chrome/browser/content_settings/host_content_settings_map.cc
>  M     chrome/browser/mac/relauncher.cc
>  M     chrome/browser/magic_iframe_browsertest.cc
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/views/frame/browser_view.cc
>  M     chrome/browser/ui/webui/options/content_settings_handler.cc
>  M     chrome/common/chrome_switches.h
>  M     chrome/nacl/nacl_broker_listener.cc
>  M     chrome/renderer/benchmarking_extension.cc
>  M     chrome/renderer/chrome_ppapi_interfaces.cc
>  M     chrome/test/gpu/webgl_conformance_tests.cc
>  M     chrome/test/ui/npapi_uitest.cc
>  M     chrome/test/ui/ppapi_uitest.cc
>  M     chrome/utility/chrome_content_utility_client.cc
>  M     content/app/content_main.cc
>  M     content/browser/browser_child_process_host.cc
>  M     content/browser/browser_main.cc
>  M     content/browser/browsing_instance.cc
>  M     content/browser/child_process_launcher.cc
>  M     content/browser/device_orientation/device_orientation_browsertest.cc
>  M     content/browser/file_system/browser_file_system_helper.cc
>  M     content/browser/file_system/file_system_browsertest.cc
>  M     content/browser/geolocation/core_location_provider_mac.mm
>  M     content/browser/geolocation/win7_location_api_win.cc
>  M     content/browser/gpu/gpu_data_manager.cc
>  M     content/browser/gpu/gpu_process_host.cc
>  M     content/browser/in_process_webkit/dom_storage_uitest.cc
>  M     content/browser/in_process_webkit/indexed_db_browsertest.cc
>  M     content/browser/in_process_webkit/indexed_db_context.cc
>  M     content/browser/in_process_webkit/indexed_db_dispatcher_host.cc
>  M     content/browser/in_process_webkit/webkit_thread.cc
>  M     content/browser/intents/intent_injector.cc
>  M     content/browser/mach_broker_mac.cc
>  M     content/browser/plugin_process_host.cc
>  M     content/browser/plugin_service.cc
>  M     content/browser/plugin_service_browsertest.cc
>  M     content/browser/ppapi_plugin_process_host.cc
>  M     content/browser/renderer_host/backing_store_manager.cc
>  M     content/browser/renderer_host/backing_store_win.cc
>  M     content/browser/renderer_host/browser_render_process_host.cc
>  M     content/browser/renderer_host/render_message_filter.cc
>  M     content/browser/renderer_host/render_process_host.cc
>  M     content/browser/renderer_host/render_process_host_browsertest.cc
>  M     content/browser/renderer_host/render_widget_host.cc
>  M     content/browser/renderer_host/render_widget_host_view_gtk.cc
>  M     content/browser/renderer_host/render_widget_host_view_win.cc
>  M     content/browser/renderer_host/resource_dispatcher_host.cc
>  M     content/browser/speech/speech_input_browsertest.cc
>  M     content/browser/tab_contents/render_view_host_manager.cc
>  M     content/browser/utility_process_host.cc
>  M     content/browser/worker_host/worker_process_host.cc
>  M     content/browser/worker_host/worker_service.cc
>  M     content/browser/zygote_host_linux.cc
>  M     content/browser/zygote_main_linux.cc
>  M     content/common/child_process_host.cc
>  M     content/common/child_thread.cc
>  D     content/common/content_switches.h
>  D     content/common/content_switches.cc
>  M     content/common/debug_flags.cc
>  M     content/common/gpu/gpu_channel.cc
>  M     content/common/handle_enumerator_win.cc
>  M     content/common/npobject_stub.cc
>  M     content/common/pepper_plugin_registry.cc
>  M     content/common/sandbox_init_wrapper_mac.cc
>  M     content/common/sandbox_init_wrapper_win.cc
>  M     content/common/sandbox_mac.mm
>  M     content/common/sandbox_policy.cc
>  M     content/content_common.gypi
>  M     content/gpu/gpu_child_thread.cc
>  M     content/gpu/gpu_main.cc
>  M     content/plugin/plugin_channel.cc
>  M     content/plugin/plugin_main.cc
>  M     content/plugin/plugin_thread.cc
>  M     content/plugin/webplugin_delegate_stub.cc
>  M     content/ppapi_plugin/ppapi_broker_main.cc
>  M     content/ppapi_plugin/ppapi_plugin_main.cc
>  M     content/ppapi_plugin/ppapi_thread.cc
>  A  +  content/public/common/content_switches.h
>  A  +  content/public/common/content_switches.cc
>  M     content/renderer/devtools_agent.cc
>  M     content/renderer/devtools_client.cc
>  M     content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc
>  M     content/renderer/media/audio_renderer_impl.cc
>  M     content/renderer/pepper_plugin_delegate_impl.cc
>  M     content/renderer/render_process_impl.cc
>  M     content/renderer/render_thread_impl.cc
>  M     content/renderer/render_view_impl.cc
>  M     content/renderer/render_widget.cc
>  M     content/renderer/renderer_accessibility.cc
>  M     content/renderer/renderer_glue.cc
>  M     content/renderer/renderer_main.cc
>  M     content/renderer/renderer_main_platform_delegate_linux.cc
>  M     content/renderer/renderer_main_platform_delegate_mac.mm
>  M     content/renderer/renderer_main_platform_delegate_win.cc
>  M     content/renderer/renderer_webkitplatformsupport_impl.cc
>  M     content/shell/shell_main_delegate.cc
>  M     content/test/content_test_launcher.cc
>  M     content/utility/utility_main.cc
>  M     content/worker/webworkerclient_proxy.cc
>  M     content/worker/worker_thread.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698