Issue 8276030: Avoid extra GCs when deserializing during incremental marking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8276030: Avoid extra GCs when deserializing during incremental marking. (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Avoid extra GCs when deserializing during incremental marking. Committed: http://code.google.com/p/v8/source/detail?r=9626

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	src/spaces.cc	View		1 chunk	+16 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-10-14 10:47:39 UTC) #2

lgtm

http://codereview.chromium.org/8276030/diff/3001/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/8276030/diff/3001/src/spaces.cc#newcode1923
src/spaces.cc:1923: if (top - bytes == allocation->address()) {
I like to have parens around top - bytes.

Expand Messages | Collapse Messages