Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 8276014: Update assert to follow the spec. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
===================================================================
--- compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (revision 409)
+++ compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (working copy)
@@ -636,7 +636,6 @@
checkAssignable(conditionNode, boolType, condition);
jat 2011/10/13 21:03:01 I know this is pre-existing code, but it seems lik
ahe 2011/10/13 21:19:41 What is it you think is wrong here? This is the *s
jat 2011/10/13 21:21:52 Ok, so if the type isn't known, checkAssignable wi
John Lenz 2011/10/13 21:35:43 I think that should be fine. x is dynamic and the
break;
}
- checkAssignable(stringType, node.getMessage());
return voidType;
}

Powered by Google App Engine
This is Rietveld 408576698