Issue 8275031: PPAPI Fullscreen: remove redundant code inherited from FlashFullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8275031: PPAPI Fullscreen: remove redundant code inherited from FlashFullscreen. (Closed)

Created:
9 years, 2 months ago by polina

Modified:
9 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

PPAPI Fullscreen: remove redundant code errouneously inherited from FlashFullscreen. Tested with ppapi/native_client/tests/ppapi_browser/ppb_fullscreen upgraded with 2D graphics. Will commit in a separate patch. BUG=41780 TEST=ppapi/tests/test_fullscreen + see above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105530

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -24 lines)			Patch
M	ppapi/api/dev/ppb_fullscreen_dev.idl	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
M	ppapi/c/dev/ppb_fullscreen_dev.h	View	1	2 chunks	+6 lines, -8 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

polina

9 years, 2 months ago (2011-10-14 18:29:48 UTC) #3

On 2011/10/14 16:31:55, brettw wrote:
> lgtm

Committed revision 105530.

Expand Messages | Collapse Messages