Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: ppapi/cpp/dev/file_chooser_dev.h

Issue 8275013: Pepper: Add a C++ wrapper for the trusted file chooser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: x Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/cpp/trusted/file_chooser_trusted.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/dev/file_chooser_dev.h
diff --git a/ppapi/cpp/dev/file_chooser_dev.h b/ppapi/cpp/dev/file_chooser_dev.h
index 6bbe0c59332dcfcf3fb6c4b34065a1156bc87d82..6efc1f8d3f536030893bb7806da187885fcde96c 100644
--- a/ppapi/cpp/dev/file_chooser_dev.h
+++ b/ppapi/cpp/dev/file_chooser_dev.h
@@ -55,7 +55,7 @@ class FileChooser_Dev : public Resource {
///
/// @return PP_OK_COMPLETIONPENDING if request to show the dialog was
/// successful, another error code from pp_errors.h on failure.
- int32_t Show(const CompletionCallback& cc);
+ virtual int32_t Show(const CompletionCallback& cc);
/// After a successful completion callback call from Show, this method may be
/// used to query the chosen files. It should be called in a loop until it
@@ -65,7 +65,7 @@ class FileChooser_Dev : public Resource {
/// PP_FileSystemType_External. If the user chose no files or cancelled the
/// dialog, then this method will simply return an is_null() FileRef the
/// first time it is called.
- FileRef GetNextChosenFile() const;
+ virtual FileRef GetNextChosenFile() const;
bbudge 2011/10/13 21:42:23 Does this need to be virtual?
viettrungluu 2011/10/13 21:47:57 No it doesn't, but I figure it should be overridea
};
} // namespace pp
« no previous file with comments | « no previous file | ppapi/cpp/trusted/file_chooser_trusted.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698