Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/trusted/validator_arm/validator.h

Issue 8275008: Make validator require read sandboxing on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/validation-report.py ('k') | src/trusted/validator_arm/validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/validator.h
===================================================================
--- src/trusted/validator_arm/validator.h (revision 6972)
+++ src/trusted/validator_arm/validator.h (working copy)
@@ -1,8 +1,7 @@
/*
- * Copyright 2009 The Native Client Authors. All rights reserved.
- * Use of this source code is governed by a BSD-style license that can
- * be found in the LICENSE file.
- * Copyright 2009, Google Inc.
+ * Copyright (c) 2011 The Native Client Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
*/
#ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_V2_VALIDATOR_H
@@ -260,6 +259,10 @@
return decoder_->base_address_register(inst_);
}
+ bool offset_is_immediate() const {
+ return decoder_->offset_is_immediate(inst_);
+ }
+
bool clears_bits(uint32_t mask) const {
return decoder_->clears_bits(inst_, mask);
}
@@ -384,8 +387,8 @@
const char * const kProblemBranchSplitsPattern = "kProblemBranchSplitsPattern";
// A branch targets an invalid code address (out of segment).
const char * const kProblemBranchInvalidDest = "kProblemBranchInvalidDest";
-// A store uses an unsafe (non-masked) base address.
-const char * const kProblemUnsafeStore = "kProblemUnsafeStore";
+// A load/store uses an unsafe (non-masked) base address.
+const char * const kProblemUnsafeLoadStore = "kProblemUnsafeLoadStore";
// A branch uses an unsafe (non-masked) destination address.
const char * const kProblemUnsafeBranch = "kProblemUnsafeBranch";
// An instruction updates a data-address register (e.g. SP) without masking.
« no previous file with comments | « src/trusted/validator_arm/validation-report.py ('k') | src/trusted/validator_arm/validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698