|
|
Revert 105300 - HQP Refactoring (in Preparation for SQLite Cache)
1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs.
2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData.
3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available.
4. Correctly handle the adding and removing of page title words when a URL change is detected.
5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h.
6. Replace static class member functions with non-friend, non-class functions for better flexibility.
7. Move convenience types out from InMemoryURLIndex class up into history namespace.
8. Rename convenience types to generalize their intent.
9. Other small cleanups.
BUG= 96731, 92718
TEST=Unit tests updated.
TBR=atwilson,brettw
Review URL: http://codereview.chromium.org/8120004
TBR=mrossetti@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105313
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+691 lines, -790 lines) |
Patch |
 |
M |
chrome/browser/autocomplete/autocomplete.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_provider.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_provider.cc
|
View
|
|
1 chunk |
+8 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_quick_provider.h
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_quick_provider.cc
|
View
|
|
5 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/autocomplete/history_quick_provider_unittest.cc
|
View
|
|
2 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/expire_history_backend.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history.cc
|
View
|
|
4 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history_backend.h
|
View
|
|
5 chunks |
+4 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history_backend.cc
|
View
|
|
6 chunks |
+2 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history_backend_unittest.cc
|
View
|
|
4 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history_notifications.h
|
View
|
|
5 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history_types.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/history/history_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/in_memory_history_backend.h
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/in_memory_history_backend.cc
|
View
|
|
3 chunks |
+29 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/in_memory_url_index.h
|
View
|
|
10 chunks |
+139 lines, -33 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/in_memory_url_index.cc
|
View
|
|
32 chunks |
+266 lines, -234 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/history/in_memory_url_index_types.h
|
View
|
|
1 chunk |
+0 lines, -206 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/history/in_memory_url_index_types_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -107 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/history/in_memory_url_index_unittest.cc
|
View
|
|
18 chunks |
+194 lines, -106 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/cancelable_request.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|