|
Revert 105404 - [Sync] Refactor non-frontend DTC to handle new API properly.
We now support disconnecting the syncableservice from the syncer via
it's sync change processor. AutofillProfile has been modified to support
this. As a result of the refactor and this disconnect functionality, we don't
need to block sync shutdown on datatypes implemented the new API, even
if they don't run on the UI thread.
From here on, datatypes that are not on the UI thread should have their
controller inherit from NewNonFrontendDataTypeController, and should
have their syncable service take ownership of the sync change processor it
receives.
A remaining TODO is to apply these changes to UI thread based datatypes.
This involves having them all take ownership of their sync change processors
(this change has their datatype controllers take ownership instead)
and creating a new parent datatype controller class that is API aware,
allowing us to remove the SyncableServiceAdapater completely. See
crbug.com/100114.
BUG= 96889
TEST=unit_tests, integration tests
Review URL: http://codereview.chromium.org/8065016
TBR=zea@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105408
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+193 lines, -1618 lines) |
Patch |
|
M |
chrome/browser/sync/api/sync_change_processor.h
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/api/sync_change_processor.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/api/syncable_service.h
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/app_data_type_controller.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/app_data_type_controller.cc
|
View
|
|
1 chunk |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/autofill_data_type_controller.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/autofill_profile_data_type_controller.h
|
View
|
|
1 chunk |
+8 lines, -45 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/autofill_profile_data_type_controller.cc
|
View
|
|
1 chunk |
+10 lines, -99 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/change_processor.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/change_processor.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/extension_data_type_controller.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/extension_data_type_controller.cc
|
View
|
|
1 chunk |
+1 line, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/frontend_data_type_controller.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/generic_change_processor.h
|
View
|
|
4 chunks |
+11 lines, -24 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/generic_change_processor.cc
|
View
|
|
7 chunks |
+10 lines, -26 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/new_non_frontend_data_type_controller.h
|
View
|
|
1 chunk |
+0 lines, -75 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/new_non_frontend_data_type_controller.cc
|
View
|
|
1 chunk |
+0 lines, -220 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/new_non_frontend_data_type_controller_mock.h
|
View
|
|
1 chunk |
+0 lines, -64 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/new_non_frontend_data_type_controller_mock.cc
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -404 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/non_frontend_data_type_controller.h
|
View
|
|
1 chunk |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/non_frontend_data_type_controller.cc
|
View
|
|
8 chunks |
+18 lines, -33 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/preference_data_type_controller.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/preference_data_type_controller.cc
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/search_engine_data_type_controller.h
|
View
|
|
3 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/search_engine_data_type_controller.cc
|
View
|
|
2 chunks |
+2 lines, -7 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/shared_change_processor.h
|
View
|
|
1 chunk |
+0 lines, -113 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/shared_change_processor.cc
|
View
|
|
1 chunk |
+0 lines, -129 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/shared_change_processor_mock.h
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/shared_change_processor_mock.cc
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/shared_change_processor_ref.h
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
|
D |
chrome/browser/sync/glue/shared_change_processor_ref.cc
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/glue/syncable_service_adapter.cc
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_factory.h
|
View
|
|
4 chunks |
+7 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_factory_impl.h
|
View
|
|
2 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_factory_impl.cc
|
View
|
|
9 chunks |
+32 lines, -44 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_factory_mock.h
|
View
|
|
2 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service_autofill_unittest.cc
|
View
|
|
7 chunks |
+19 lines, -24 lines |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service_mock.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/sync/profile_sync_service_preference_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/webdata/autofill_profile_syncable_service.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/webdata/autofill_profile_syncable_service.cc
|
View
|
|
10 chunks |
+14 lines, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc
|
View
|
|
6 chunks |
+27 lines, -24 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|