Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 8274012: Wait for URLBlacklist update tasks on automation tests. (Closed)

Created:
9 years, 2 months ago by Joao da Silva
Modified:
9 years, 2 months ago
CC:
chromium-reviews, kkania
Visibility:
Public.

Description

Wait for URLBlacklist update tasks on automation tests. Also introduced BrowserThread::WaitForPendingTasksOn(), and removing SignalingTask. BUG=100217 TEST=policy.PolicyTest.testBlacklistPolicy doesn't flake Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107113

Patch Set 1 #

Total comments: 8

Patch Set 2 : Added BrowserThread::WaitForPendingTasksOn, removed SignalingTask #

Total comments: 1

Patch Set 3 : Removed BrowserThread:: extensions, simpler test, re-enabled testBlacklistPolicy pyauto test #

Patch Set 4 : Rebased #

Total comments: 1

Patch Set 5 : Reviewed #

Total comments: 3

Patch Set 6 : Non-blocking version of loop flush #

Patch Set 7 : Added CHECKs #

Total comments: 11

Patch Set 8 : Reviewed: removed CHECKs, added comment, nits #

Total comments: 2

Patch Set 9 : Rebased #

Patch Set 10 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 7 8 7 chunks +53 lines, -51 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
Joao da Silva
Hey Nirnimesh, there is a very remote possibility that the blacklist hasn't been updated yet ...
9 years, 2 months ago (2011-10-13 20:00:33 UTC) #1
Paweł Hajdan Jr.
http://codereview.chromium.org/8274012/diff/1/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/8274012/diff/1/chrome/browser/automation/testing_automation_provider.cc#newcode181 chrome/browser/automation/testing_automation_provider.cc:181: class SignalingTask : public Task { Huh? This is ...
9 years, 2 months ago (2011-10-13 20:10:59 UTC) #2
Joao da Silva
Adding @sky for an owner review of content/browser. If this is acceptable to the current ...
9 years, 2 months ago (2011-10-13 21:32:27 UTC) #3
sky
I think this is scary, and at a minimum you should DCHECK that not on ...
9 years, 2 months ago (2011-10-13 21:55:50 UTC) #4
jam
http://codereview.chromium.org/8274012/diff/1003/content/browser/browser_thread.h File content/browser/browser_thread.h (right): http://codereview.chromium.org/8274012/diff/1003/content/browser/browser_thread.h#newcode176 content/browser/browser_thread.h:176: static bool WaitForPendingTasksOn(ID identifier); this is most certainly a ...
9 years, 2 months ago (2011-10-14 17:19:29 UTC) #5
Joao da Silva
Removed the changes in content/, and @sky and @jam as reviewers. @nirnimesh: please have another ...
9 years, 2 months ago (2011-10-18 10:13:50 UTC) #6
Paweł Hajdan Jr.
http://codereview.chromium.org/8274012/diff/11001/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/8274012/diff/11001/chrome/browser/automation/testing_automation_provider.cc#newcode181 chrome/browser/automation/testing_automation_provider.cc:181: CHECK(!BrowserThread::CurrentlyOn(identifier)); I commented about those lines. Please apply that ...
9 years, 2 months ago (2011-10-18 10:30:45 UTC) #7
Nirnimesh
> It was about not using CHECKs in test code but returning bool instead. Maybe ...
9 years, 2 months ago (2011-10-18 18:01:31 UTC) #8
Nirnimesh
LGTM
9 years, 2 months ago (2011-10-18 18:13:26 UTC) #9
jam
just a sec: I thought this would be done in tests only. But this code ...
9 years, 2 months ago (2011-10-18 18:28:58 UTC) #10
Nirnimesh
On 2011/10/18 18:28:58, John Abd-El-Malek wrote: > just a sec: I thought this would be ...
9 years, 2 months ago (2011-10-18 18:36:22 UTC) #11
jam
(sorry for the delay, I missed this) On 2011/10/18 18:36:22, Nirnimesh wrote: > On 2011/10/18 ...
9 years, 2 months ago (2011-10-19 04:37:57 UTC) #12
Paweł Hajdan Jr.
Nirnimesh: CHECK or DCHECK crashes the entire browser, and it's especially painful under ui_tests. The ...
9 years, 2 months ago (2011-10-19 09:20:02 UTC) #13
Nirnimesh
On 2011/10/19 09:20:02, Paweł Hajdan Jr. wrote: > Nirnimesh: CHECK or DCHECK crashes the entire ...
9 years, 2 months ago (2011-10-19 10:30:38 UTC) #14
Paweł Hajdan Jr.
On 2011/10/19 10:30:38, Nirnimesh wrote: > I understand that crashing can get painful in the ...
9 years, 2 months ago (2011-10-19 18:52:12 UTC) #15
Nirnimesh
> Good question. My idea is that CHECKs in the browser code are "legitimate" and ...
9 years, 2 months ago (2011-10-19 19:11:00 UTC) #16
jam
On 2011/10/19 09:20:02, Paweł Hajdan Jr. wrote: > John: I don't see a way to ...
9 years, 2 months ago (2011-10-19 23:56:27 UTC) #17
Paweł Hajdan Jr.
On 2011/10/19 19:11:00, Nirnimesh wrote: > > Good question. My idea is that CHECKs in ...
9 years, 2 months ago (2011-10-21 08:43:12 UTC) #18
Joao da Silva
Thanks all for the comments. The patch has been refactored as per @jam's suggestion of ...
9 years, 2 months ago (2011-10-21 12:59:58 UTC) #19
Paweł Hajdan Jr.
http://codereview.chromium.org/8274012/diff/25006/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/8274012/diff/25006/chrome/browser/automation/testing_automation_provider.cc#newcode182 chrome/browser/automation/testing_automation_provider.cc:182: CHECK(BrowserThread::PostTask(id, FROM_HERE, task)); Please make it return the value ...
9 years, 2 months ago (2011-10-21 15:13:17 UTC) #20
jam
thanks, this looks much better Why are you CHECKing the result of BrowserThread::PostTask? This will ...
9 years, 2 months ago (2011-10-21 16:06:46 UTC) #21
Joao da Silva
@willchan: please have a look at the nested Binds. The purpose is to solve flakes ...
9 years, 2 months ago (2011-10-21 16:25:53 UTC) #22
willchan no longer on Chromium
http://codereview.chromium.org/8274012/diff/25006/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/8274012/diff/25006/chrome/browser/automation/testing_automation_provider.cc#newcode5906 chrome/browser/automation/testing_automation_provider.cc:5906: PostTask(BrowserThread::IO, On 2011/10/21 16:25:53, Joao da Silva wrote: > ...
9 years, 2 months ago (2011-10-21 20:50:29 UTC) #23
Joao da Silva
@willchan: thanks for taking a look! @phajdan.jr: I agree with John's remarks about checking PostTask's ...
9 years, 2 months ago (2011-10-22 11:26:49 UTC) #24
jam
http://codereview.chromium.org/8274012/diff/29001/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/8274012/diff/29001/chrome/browser/automation/testing_automation_provider.cc#newcode183 chrome/browser/automation/testing_automation_provider.cc:183: BrowserThread::PostTask(id, FROM_HERE, task) so i understand: we need this ...
9 years, 2 months ago (2011-10-25 05:42:10 UTC) #25
jam
also lgtm
9 years, 2 months ago (2011-10-25 05:42:20 UTC) #26
Paweł Hajdan Jr.
LGTM
9 years, 2 months ago (2011-10-25 07:22:22 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/8274012/34002
9 years, 2 months ago (2011-10-25 13:11:35 UTC) #28
Joao da Silva
@jam: see inline. Maybe Will knows a better way around this... http://codereview.chromium.org/8274012/diff/29001/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): ...
9 years, 2 months ago (2011-10-25 13:13:37 UTC) #29
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 14:25:05 UTC) #30
Change committed as 107113

Powered by Google App Engine
This is Rietveld 408576698