Minimum size for aura window

ui/aura/window_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/stringprintf.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 704 matching lines @@
   EXPECT_EQ(original_bounds, w->bounds());
 
   // Fullscreen
   w->Fullscreen();
   EXPECT_EQ(ui::SHOW_STATE_FULLSCREEN, w->show_state());
   EXPECT_EQ(desktop_bounds, w->bounds());
   w->Restore();
   EXPECT_EQ(ui::SHOW_STATE_NORMAL, w->show_state());
   EXPECT_EQ(original_bounds, w->bounds());
 
   // Fullscreen twice

[Ben Goodger (Google), 2011/10/14 15:40:05]

This comment just says what the code does, not what assumption it's testing
against. How about:

// Calling Fullscreen() twice should have no additional effect.

[oshima, 2011/10/15 02:10:50]

Done.

   w->Fullscreen();
   w->Fullscreen();
   EXPECT_EQ(desktop_bounds, w->bounds());
   w->Restore();
   EXPECT_EQ(ui::SHOW_STATE_NORMAL, w->show_state());
   EXPECT_EQ(original_bounds, w->bounds());
+
+  // SetBounds in fullscreen mode

[Ben Goodger (Google), 2011/10/14 15:40:05]

Same here.

// Calling SetBounds() while in full screen mode should only update the restored
bounds not change the bounds of the window.

[oshima, 2011/10/15 02:10:50]

Done.

+  gfx::Rect new_bounds(50, 50, 50, 50);
+  w->Fullscreen();
+  w->SetBounds(new_bounds);
+  EXPECT_EQ(desktop_bounds, w->bounds());
+  w->Restore();
+  EXPECT_EQ(new_bounds, w->bounds());
 }
 
 TEST_F(WindowTest, Maximized) {
   gfx::Rect original_bounds = gfx::Rect(100, 100, 100, 100);
   gfx::Rect desktop_bounds(Desktop::GetInstance()->GetSize());
   scoped_ptr<Window> w(CreateTestWindowWithDelegate(
       NULL, 1, original_bounds, NULL));
   EXPECT_EQ(original_bounds, w->bounds());
 
   // Maximized
@@ skipping 21 matching lines @@
   EXPECT_EQ(max_bounds, w->bounds());
   w->Fullscreen();
   EXPECT_EQ(ui::SHOW_STATE_FULLSCREEN, w->show_state());
   EXPECT_EQ(desktop_bounds, w->bounds());
   w->Maximize();
   EXPECT_EQ(ui::SHOW_STATE_MAXIMIZED, w->show_state());
   EXPECT_EQ(max_bounds, w->bounds());
   w->Restore();
   EXPECT_EQ(ui::SHOW_STATE_NORMAL, w->show_state());
   EXPECT_EQ(original_bounds, w->bounds());
+
+  // SetBounds in maximized mode

[Ben Goodger (Google), 2011/10/14 15:40:05]

Same as above.

[oshima, 2011/10/15 02:10:50]

Done.

+  gfx::Rect new_bounds(50, 50, 50, 50);
+  w->Maximize();
+  w->SetBounds(new_bounds);
+  EXPECT_EQ(max_bounds, w->bounds());
+  w->Restore();
+  EXPECT_EQ(new_bounds, w->bounds());
 }
 
 // Various assertions for activating/deactivating.
 TEST_F(WindowTest, Deactivate) {
   TestWindowDelegate d1;
   TestWindowDelegate d2;
   scoped_ptr<Window> w1(
       CreateTestWindowWithDelegate(&d1, 1, gfx::Rect(), NULL));
   scoped_ptr<Window> w2(
       CreateTestWindowWithDelegate(&d2, 2, gfx::Rect(), NULL));
@@ skipping 14 matching lines @@
   EXPECT_EQ(w1.get(), parent->children()[1]);
 
   // Deactivate w1 and make sure w2 becomes active and frontmost.
   w1->Deactivate();
   EXPECT_FALSE(w1->IsActive());
   EXPECT_TRUE(w2->IsActive());
   EXPECT_EQ(w2.get(), parent->children()[1]);
 }
 
 class WindowObserverTest : public WindowTest,
-                     public WindowObserver {
+                           public WindowObserver {
  public:
   WindowObserverTest() : added_count_(0), removed_count_(0) {}
 
   virtual ~WindowObserverTest() {}
 
   // Returns a description of the WindowObserver methods that have been invoked.
   std::string WindowObserverCountStateAndClear() {
     std::string result(
         base::StringPrintf("added=%d removed=%d",
         added_count_, removed_count_));
@@ skipping 86 matching lines @@
 
   w3->Activate();
   EXPECT_EQ(w2.get(), active());
 
   w1->Activate();
   EXPECT_EQ(w1.get(), active());
 }
 
 }  // namespace test
 }  // namespace aura