Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: chrome/browser/resources/options/autofill_options_list.js

Issue 8273026: [Multi Profile] Double-clicking an item in the user list should edit that profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add dblclick to list, remove from autofill Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/personal_options_profile_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/autofill_options_list.js
diff --git a/chrome/browser/resources/options/autofill_options_list.js b/chrome/browser/resources/options/autofill_options_list.js
index c6591ed84e02cf60b8a400542b29029d7b3f812c..89ed6bbbe45c8e9f7fad92665e7a119cc77c480b 100644
--- a/chrome/browser/resources/options/autofill_options_list.js
+++ b/chrome/browser/resources/options/autofill_options_list.js
@@ -318,7 +318,6 @@ cr.define('options.autofillOptions', function() {
DeletableItemList.prototype.decorate.call(this);
this.addEventListener('blur', this.onBlur_);
- this.addEventListener('dblclick', this.onDoubleClick_);
},
/**
@@ -328,28 +327,6 @@ cr.define('options.autofillOptions', function() {
onBlur_: function() {
this.selectionModel.unselectAll();
},
-
- /**
- * When a list item is double clicked, open the corresponding profile for
- * editing.
- * @param {Event} event The double-click event.
- * @private
- */
- onDoubleClick_: function(event) {
- if (this.disabled)
- return;
-
- var target = this.getListItemAncestor(event.target);
- if (target)
- this.activateItemAtIndex_(this.getIndexOfListItem(target));
- },
-
- /**
- * Opens the item at |index| for editing. Subclasses should override.
- * @param {Number} index The item index.
- */
- activateItemAtIndex_: function(index) {
- },
};
/**
@@ -367,7 +344,7 @@ cr.define('options.autofillOptions', function() {
},
/** @inheritDoc */
- activateItemAtIndex_: function(index) {
+ activateItemAtIndex: function(index) {
AutofillOptions.loadAddressEditor(this.dataModel.item(index)[0]);
},
@@ -397,7 +374,7 @@ cr.define('options.autofillOptions', function() {
},
/** @inheritDoc */
- activateItemAtIndex_: function(index) {
+ activateItemAtIndex: function(index) {
AutofillOptions.loadCreditCardEditor(this.dataModel.item(index)[0]);
},
« no previous file with comments | « no previous file | chrome/browser/resources/options/personal_options_profile_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698