[Multi Profile] Double-clicking an item in the user list should edit that profile.

chrome/browser/resources/options/personal_options_profile_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.personal_options', function() {
   const DeletableItem = options.DeletableItem;
   const DeletableItemList = options.DeletableItemList;
   const ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
   var localStrings = new LocalStrings();
@@ skipping 41 matching lines @@
       nameEl.className = 'profile-item';
       if (profileInfo.isCurrentProfile)
         nameEl.classList.add('profile-item-current');
 
       var displayName = profileInfo.name;
       if (profileInfo.isCurrentProfile)
         displayName = localStrings.getStringF(
             'profilesListItemCurrent',
             profileInfo.name)
       nameEl.textContent = displayName;
-    },
+    }

[James Hawkins, 2011/10/14 20:51:24]

Why did you remove the comma?

[binji, 2011/10/14 21:17:14]

Strange, I thought it complained about it once.

   };
 
   var ProfileList = cr.ui.define('list');
 
   ProfileList.prototype = {
     __proto__: DeletableItemList.prototype,
 
     /** @inheritDoc */
     decorate: function() {
       DeletableItemList.prototype.decorate.call(this);
       this.selectionModel = new ListSingleSelectionModel();
+
+      this.addEventListener('dblclick', this.handleDoubleClick_);
     },
 
     /** @inheritDoc */
     createItem: function(pageInfo) {
       var item = new ProfileListItem(pageInfo);
       return item;
     },
 
     /** @inheritDoc */
     deleteItemAtIndex: function(index) {
       ManageProfileOverlay.showDeleteDialog(this.dataModel.item(index));
     },
+
+    /**
+     * Callback for the double click event.
+     * @param {Event} e The mouse event object.
+     * @private
+     */
+    handleDoubleClick_: function(e) {

[James Hawkins, 2011/10/14 20:51:24]

Hmm, logic for double clicking used to be handled in list.js, but was removed
recently by me because we removed that functionality from the one user (which
has since been re-added).  Can you move this back into list.js and also fix-up
the Autofill list code to use that as well?

[binji, 2011/10/14 21:17:14]

Done.

+      var target = this.getListItemAncestor(e.target);
+      if (target)
+        this.activateItemAtIndex(this.getIndexOfListItem(target));
+    },
+
+    /**
+     * Called when a list item is activated, currently only by a double click
+     * event.
+     * @param {number} index The index of the activated item.
+     */
+    activateItemAtIndex: function(index) {
+      ManageProfileOverlay.showManageDialog(this.dataModel.item(index));
+    }
   };
 
   return {
     ProfileList: ProfileList
   };
 });