[Multi Profile] Double-clicking an item in the user list should edit that profile.

[Multi Profile] Double-clicking an item in the user list should edit that profile.

BUG=92536
TEST=Go to chrome://settings/personal. Ensure there are >= 2 users. Double-click a user item. The edit user dialog should open.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105926

[binji, 2011-10-14 20:08:18]

Looks like we want this again -- see bug.

[James Hawkins, 2011-10-14 20:51:24]

http://codereview.chromium.org/8273026/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/personal_options_profile_list.js (right):

http://codereview.chromium.org/8273026/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/personal_options_profile_list.js:62: }
Why did you remove the comma?

http://codereview.chromium.org/8273026/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/personal_options_profile_list.js:94:
handleDoubleClick_: function(e) {
Hmm, logic for double clicking used to be handled in list.js, but was removed
recently by me because we removed that functionality from the one user (which
has since been re-added).  Can you move this back into list.js and also fix-up
the Autofill list code to use that as well?

[binji, 2011-10-14 21:17:14]

http://codereview.chromium.org/8273026/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/personal_options_profile_list.js (right):

http://codereview.chromium.org/8273026/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/personal_options_profile_list.js:62: }
On 2011/10/14 20:51:24, James Hawkins wrote:
> Why did you remove the comma?

Strange, I thought it complained about it once.

http://codereview.chromium.org/8273026/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/personal_options_profile_list.js:94:
handleDoubleClick_: function(e) {
On 2011/10/14 20:51:24, James Hawkins wrote:
> Hmm, logic for double clicking used to be handled in list.js, but was removed
> recently by me because we removed that functionality from the one user (which
> has since been re-added).  Can you move this back into list.js and also fix-up
> the Autofill list code to use that as well?

Done.

[James Hawkins, 2011-10-14 22:32:38]

lgtm

[commit-bot: I haz the power, 2011-10-14 22:41:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8273026/4001

[commit-bot: I haz the power, 2011-10-15 02:12:38]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105607, job name
was 8273026-4001 (previous was lost) (retry) (previous was lost) (previous was
lost).

[commit-bot: I haz the power, 2011-10-17 20:13:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8273026/4001

[commit-bot: I haz the power, 2011-10-17 21:39:17]

Change committed as 105926