Implemented cancel connect.

Implemented cancel connect.

BUG=None
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105525

[Jamie, 2011-10-13 23:30:31]

This CL implements cancel for the client-side web-app. Prior to a response to
the support id lookup, cancellation is handled using a session id to ignore any
response received after Cancel is clicked. After that point, cancellation is
handled by setting the session object to null and detecting that situation when
the state changes, preventing the app switching to in-session mode.

[Wez, 2011-10-14 01:21:25]

lgtm

LGTM

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting.js
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:582: ++remoting.sessionId;
Consider tweaking the xhr.get() call to return the XMLHttpRequest, and storing
that so that it can be abort()'d, to avoid the need for the sessionId logic.

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:671:
document.getElementById('cancel-button').disabled = true;
nit: Indentation.

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:673: case remoting.AppMode.HOST:
nit: Is this the right indentation for case?

[Jamie, 2011-10-14 18:17:06]

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting.js
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:582: ++remoting.sessionId;
On 2011/10/14 01:21:26, Wez wrote:
> Consider tweaking the xhr.get() call to return the XMLHttpRequest, and storing
> that so that it can be abort()'d, to avoid the need for the sessionId logic.

Done.

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:671:
document.getElementById('cancel-button').disabled = true;
On 2011/10/14 01:21:26, Wez wrote:
> nit: Indentation.

Done.

http://codereview.chromium.org/8273024/diff/1/remoting/webapp/me2mom/remoting...
remoting/webapp/me2mom/remoting.js:673: case remoting.AppMode.HOST:
On 2011/10/14 01:21:26, Wez wrote:
> nit: Is this the right indentation for case?

Apparently not. Fixed.

[Wez, 2011-10-14 18:44:02]

lgtm

http://codereview.chromium.org/8273024/diff/7001/remoting/webapp/me2mom/remot...
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/8273024/diff/7001/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:502: if (remoting.session) {
We shouldn't even reach here if !remoting.session?

http://codereview.chromium.org/8273024/diff/7001/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:548: accessCode.value = '';  // The code has
been validated and won't work again.
nit: Move this comment above the var accessCode line and re-phrase e.g. "Clear
the Access Code, since it cannot be used again."?

http://codereview.chromium.org/8273024/diff/7001/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:586: remoting.supportHostsXhr = null;
nit: Should we check that xhr == supportHostsXhr first?

http://codereview.chromium.org/8273024/diff/7001/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:681: break;
nit: This might actually read better as an if...else.