Remove an unnecessary comparison in OriginIdentifierValueMap::EntryMapKey::operator<

Remove an unnecessary comparison in OriginIdentifierValueMap::EntryMapKey::operator<

Originally reported by viva64 using PVS Studio ( http://www.viva64.com/en/b/0113/ Fragment N8)

BUG=100213
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105763

[Ryan Sleevi, 2011-10-13 23:10:08]

jochen: PTAL. content_type is a ContentSettingsType, which is an enum defined in
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/common/content...

Thus, no operator overloading, so only the < is needed.

[jochen (gone - plz use gerrit), 2011-10-13 23:20:46]

http://codereview.chromium.org/8273023/diff/1/chrome/browser/content_settings...
File
chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc
(left):

http://codereview.chromium.org/8273023/diff/1/chrome/browser/content_settings...
chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc:63:
else if (other.content_type > content_type)
I think that should be content_type > other.content_type ?

[Ryan Sleevi, 2011-10-13 23:23:49]

Wow. Totally sorry about that - I missed that it wasn't the common != return <
pattern.

PTAL at patchset 2.

[Ryan Sleevi, 2011-10-17 01:11:25]

ping

[jochen (gone - plz use gerrit), 2011-10-17 01:14:37]

lgtm

[commit-bot: I haz the power, 2011-10-17 01:16:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8273023/4001

[commit-bot: I haz the power, 2011-10-17 01:18:14]

Try job failure for 8273023-4001 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-17 01:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8273023/4001

[commit-bot: I haz the power, 2011-10-17 01:20:57]

Try job failure for 8273023-4001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-17 01:40:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8273023/4001

[commit-bot: I haz the power, 2011-10-17 01:41:58]

Try job failure for 8273023-4001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-17 02:24:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8273023/4001

[commit-bot: I haz the power, 2011-10-17 03:29:03]

Change committed as 105763