Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 8273009: Don't use `sizeof(a) / sizeof(a)` to compute the number of elements in array a. (Closed)

Created:
9 years, 2 months ago by Nico
Modified:
9 years, 2 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't use `sizeof(a) / sizeof(a)` to compute the number of elements in array a. The interesting parts of the patch are by wtc. Found by PVS Studio: http://www.viva64.com/en/b/0113/ , N12 BUG=100278 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105467

Patch Set 1 #

Patch Set 2 : wtc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/shared_memory_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
M-A Ruel
lgtm
9 years, 2 months ago (2011-10-13 18:53:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8273009/1
9 years, 2 months ago (2011-10-13 18:54:11 UTC) #2
commit-bot: I haz the power
Presubmit check for 8273009-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 2 months ago (2011-10-13 18:54:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8273009/1
9 years, 2 months ago (2011-10-13 18:58:42 UTC) #4
Mark Mentovai
LGTM
9 years, 2 months ago (2011-10-13 18:58:49 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-13 20:38:23 UTC) #6
M-A Ruel
On 2011/10/13 20:38:23, I haz the power (commit-bot) wrote: > The commit queue went berserk ...
9 years, 2 months ago (2011-10-13 20:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8273009/1
9 years, 2 months ago (2011-10-13 20:40:23 UTC) #8
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-13 22:47:26 UTC) #9
M-A Ruel
Humm, I looked at it well and it's indeed causing a failure. You'll need to ...
9 years, 2 months ago (2011-10-13 23:00:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8273009/1003
9 years, 2 months ago (2011-10-13 23:46:07 UTC) #11
wtc
Patch Set 2 LGTM.
9 years, 2 months ago (2011-10-13 23:57:01 UTC) #12
commit-bot: I haz the power
List of reviewers changed.
9 years, 2 months ago (2011-10-14 01:10:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8273009/1003
9 years, 2 months ago (2011-10-14 06:16:37 UTC) #14
commit-bot: I haz the power
9 years, 2 months ago (2011-10-14 07:28:08 UTC) #15
Change committed as 105467

Powered by Google App Engine
This is Rietveld 408576698