Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8271025: Moved mobile activation into its own modal dialog (Closed)

Created:
9 years, 2 months ago by zel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Dmitry Titov, jianli, prasadt, dcheng
Visibility:
Public.

Description

Moved mobile activation into its own modal dialog. BUG=chromium-os:21738, chromium-os:20525 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106964

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 23

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 2

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -334 lines) Patch
D chrome/browser/resources/file_manager/css/dialogs.css View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/resources/file_manager/js/dialogs.js View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -235 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 4 5 6 7 8 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/mobile_setup.html View 1 2 3 4 5 6 7 8 5 chunks +42 lines, -27 lines 0 comments Download
M chrome/browser/resources/mobile_setup.js View 1 2 3 4 5 6 7 8 3 chunks +31 lines, -5 lines 0 comments Download
A + chrome/browser/resources/shared/css/dialogs.css View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/shared/js/cr/ui/dialogs.js View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/shared_resources.grd View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/mobile_setup_dialog.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 1 2 3 4 5 6 7 1 chunk +87 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
zel
...I have also moved dialogs.js/css from file manager into shared resources
9 years, 2 months ago (2011-10-15 01:11:23 UTC) #1
xiyuan
http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/mobile_setup.html File chrome/browser/resources/mobile_setup.html (right): http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/mobile_setup.html#newcode8 chrome/browser/resources/mobile_setup.html:8: -webkit-box-flex: 1; We can get rid of this since ...
9 years, 2 months ago (2011-10-15 15:56:18 UTC) #2
rginda
http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/file_manager/js/dialogs.js File chrome/browser/resources/file_manager/js/dialogs.js (left): http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/file_manager/js/dialogs.js#oldcode25 chrome/browser/resources/file_manager/js/dialogs.js:25: * Clients should override these with localized labels. You're ...
9 years, 2 months ago (2011-10-15 16:53:46 UTC) #3
zel
http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/mobile_setup.html File chrome/browser/resources/mobile_setup.html (right): http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/mobile_setup.html#newcode8 chrome/browser/resources/mobile_setup.html:8: -webkit-box-flex: 1; On 2011/10/15 15:56:19, xiyuan wrote: > We ...
9 years, 2 months ago (2011-10-18 22:22:15 UTC) #4
jennb
http://codereview.chromium.org/8271025/diff/22001/chrome/browser/ui/browser_window.h File chrome/browser/ui/browser_window.h (right): http://codereview.chromium.org/8271025/diff/22001/chrome/browser/ui/browser_window.h#newcode338 chrome/browser/ui/browser_window.h:338: // Shows the Task manager. Drive by... is this ...
9 years, 2 months ago (2011-10-18 23:20:02 UTC) #5
zel
http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/file_manager/js/dialogs.js File chrome/browser/resources/file_manager/js/dialogs.js (left): http://codereview.chromium.org/8271025/diff/15003/chrome/browser/resources/file_manager/js/dialogs.js#oldcode25 chrome/browser/resources/file_manager/js/dialogs.js:25: * Clients should override these with localized labels. On ...
9 years, 2 months ago (2011-10-18 23:43:11 UTC) #6
sky
chrome/browser/ui/ LGTM
9 years, 2 months ago (2011-10-18 23:50:48 UTC) #7
xiyuan
LGTM with nits http://codereview.chromium.org/8271025/diff/29023/chrome/browser/resources/mobile_setup.html File chrome/browser/resources/mobile_setup.html (right): http://codereview.chromium.org/8271025/diff/29023/chrome/browser/resources/mobile_setup.html#newcode11 chrome/browser/resources/mobile_setup.html:11: display: -webkit-box; nit: I still think ...
9 years, 2 months ago (2011-10-19 00:58:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/8271025/35001
9 years, 2 months ago (2011-10-24 19:17:19 UTC) #9
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 19:17:24 UTC) #10 
Can't apply patch for file chrome/browser/resources/shared/js/cr/ui/dialogs.js.
While running patch -p0 --forward --force;
patching file chrome/browser/resources/shared/js/cr/ui/dialogs.js
Hunk #1 FAILED at 24.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/shared/js/cr/ui/dialogs.js.rej

Powered by Google App Engine
This is Rietveld 408576698