Issue 8271005: Adapt to latest spec changes for Proxy.create[Function].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8271005: Adapt to latest spec changes for Proxy.create[Function]. (Closed)

Created:
9 years, 2 months ago by rossberg

Modified:
9 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Adapt to latest spec changes for Proxy.create[Function]. R=mstarzinger@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9761

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -10 lines)			Patch
M	src/messages.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/proxy.js	View	2 chunks	+7 lines, -9 lines	2 comments	Download
M	test/mjsunit/harmony/proxies.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). http://codereview.chromium.org/8271005/diff/1/src/proxy.js File src/proxy.js (right): http://codereview.chromium.org/8271005/diff/1/src/proxy.js#newcode47 src/proxy.js:47: var construct I think that "var" ...

9 years, 2 months ago (2011-10-13 16:22:48 UTC) #2

rossberg

9 years, 2 months ago (2011-10-24 15:59:49 UTC) #3

http://codereview.chromium.org/8271005/diff/1/src/proxy.js
File src/proxy.js (right):

http://codereview.chromium.org/8271005/diff/1/src/proxy.js#newcode47
src/proxy.js:47: var construct
On 2011/10/13 16:22:48, Michael Starzinger wrote:
> I think that "var" can be removed now.

Done.

Expand Messages | Collapse Messages